Closed
Bug 495013
Opened 15 years ago
Closed 15 years ago
Bring back "publish to collection" AJAX action on add-on details page
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.6
People
(Reporter: stephend, Assigned: u278084)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
1.45 KB,
patch
|
wenzel
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Load https://preview.addons.mozilla.org/en-US/firefox/addon/1843 2. Under "Add to a Collection," just leave the <select> as-is and click "Publish." Expected: Button should be disabled Actual: https://preview.addons.mozilla.org/en-US/firefox/collections/addtocollection loads and yields, "Missing argument: addon_id or collection_id"
Comment 1•15 years ago
|
||
There used to be an AJAX action on this button, so that only non-JS users will go to the addtocollection page. For some reason it is gone -- probably a problem with the details page redesign?
Keywords: regression
Hardware: x86 → All
Summary: Disable the Publish button when no collection is selected → Bring back "publish to collection" AJAX action on add-on details page
Target Milestone: --- → 5.0.6
This seems to have regressed when bug 490887 landed. Changing the <button> back to a <input type="submit"/> causes the form from being processed until a collection is specified. Patch hopefully soon!
Attachment #380022 -
Flags: review?(rdoherty)
Comment 4•15 years ago
|
||
We're using <button> all over the place now. Why are we changing the JS instead of just switching it back to a <button>? (I didn't read the patch carefully, but I don't want to break the buttons in other places)
Comment 5•15 years ago
|
||
Will the <button> submit the form when JS is disabled? I didn't think it would. If it does, <button> is fine with me. If it does not, it breaks non-JS fallback, which is neither useful nor necessary.
Comment 6•15 years ago
|
||
The new collections pages are all buttons, all the time, and they work fine with or without js.
Version: unspecified → 0.9
Just to clear up some confusion, the patch keeps the button element but changes the JS to work with the button element. And yes, it button will submit the form when JS is disabled.
Updated•15 years ago
|
Attachment #380022 -
Flags: review?(rdoherty) → review+
Comment 8•15 years ago
|
||
Comment on attachment 380022 [details] [diff] [review] changed jquery Wfm.
In r26596
Reporter | ||
Comment 10•15 years ago
|
||
Verified FIXED -- a user can still click Publish with the default option selected and get the error mentioned in comment 0, but only with JS disabled, and I don't think there's any way around that, and it's certainly an edge case.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 11•15 years ago
|
||
removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"
Keywords: push-needed
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•