Closed Bug 495025 Opened 13 years ago Closed 13 years ago

content/xul/content builds its tests unconditionally

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch FixSplinter Review
Does this spoil the magic parallel pixie dust? According to my unscientific "study" (of things which failed to put their makefiles in toolkit-makefiles.sh), this is one of the few places which unconditionally builds tests.
Attachment #379829 - Flags: review?(ted.mielczarek)
Attachment #379829 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 379829 [details] [diff] [review]
Fix

No, PARALLEL_DIRS should handle this just fine. You just obviously won't get any parallelism with tests disabled.
http://hg.mozilla.org/mozilla-central/rev/7ba650e10a78
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.