495055 - nsIWebBrowserStream::AppendToStream(const PRUint8 *aData, PRUint32 aLen) does not return for data greater than 64 kbyte

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Kerim]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)

The nsIWebBrowserStream::AppendToStream(const PRUint8 *aData, PRUint32 aLen) cannot process data over 64 kybtes.

A workaround is to split up the data and append only chunks of 64 kbytes, but the AppendToStream function should either do that itself or report an error.

Reproducible: Always

Steps to Reproduce:
1. open nsIWebBrowserStream
2. call AppendToStream(data,len) with data having a length of more than 64 kbytes
Actual Results:  
freezes, no return

Expected Results:  
NSFAILED( nsresult ) or the function should have splitted up the chunks to the correct buffer limits and therefore succeded in appending the data

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

http://mxr.mozilla.org/mozilla-central/source/embedding/browser/webBrowser/nsEmbedStream.cpp#83
83   rv = NS_NewPipe(getter_AddRefs(bufInStream),
84                   getter_AddRefs(bufOutStream));


That pipe's limited to storing 64 KB at a time, it should probably be unlimited.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

By "it" I mean that nsEmbedStream should pass the right arguments to NS_NewPipe to make it unlimited.

Comment 3

[Hector Chu]

This bug can be closed now as it was fixed in 293670.

Comment 4

[Hector Chu]

Sorry here is the link: bug 293670

Comment 5

[Eric Shepherd [:sheppy]]

This has a mention here now:

https://developer.mozilla.org/en/Firefox_3.6_for_developers#Miscellaneous