Camino opens external link in minimized window even though another is at front

NEW
Unassigned

Status

--
minor
10 years ago
8 years ago

People

(Reporter: David, Unassigned)

Tracking

Details

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en; rv:1.9.0.8pre) Gecko/2009022317 Camino/2.0b2 (like Firefox/3.0.8pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en; rv:1.9.0.8pre) Gecko/2009022317 Camino/2.0b2 (like Firefox/3.0.8pre)

If more than one application has been to front, since using Camino, and you send a link to Camino from an external application, minimized windows are selected for opening the link.

Reproducible: Always

Steps to Reproduce:
1. Have to windows open in Camino, one of them minimized.
2. Go to another application, and then go to a third one.
3. Click on a link in the third application (Like, in a RSS reader)
Actual Results:  
The link is opened in the window that is minimized (Which is then un-minimized) instead of the one to the front.

Expected Results:  
No matter how many applications you switch to, Camino should always use the front most window. It should only used minimized windows if no other windows are open in Camino.

I'm using 2.0b2. I can't tell if Camino thinks that the first window is the one to use, since it was the one created first?
(Reporter)

Comment 1

10 years ago
Erh, step one should read "Have two windows open...".

Comment 2

10 years ago
I can't repro this using the STR; we'll need to narrow it down more.
- I assume you have the pref to open URLs from external apps in tabs?
- Are you using Spaces at all? Are the apps you are switching to in other spaces?
- Do the apps you switch to matter?

(Smokey was theorizing this might be similar in nature to bug 495729 in that we seem to be getting the wrong window from frontmostBrowserWindow, which is why I'm wondering if it's Spaces-related; if so we could probably fix it a similar way (either return the first unminimized window, or make a new window, depending on what we think the right behavior is.)
(Reporter)

Comment 3

10 years ago
• Yes, I have external links to open in tabs, set in preferences.
• No, I'm not using Spaces at all. It is turned off.
• Not as far as I can see. It just seem to happen as soon as I've switched to at least 2 applications.

I'll try to nail it down more precisely, and do more testing.
(Reporter)

Comment 4

10 years ago
Okay, I just tried out quite a few things, and it seems my steps are totally wrong. It is actually related to the fact that I hide (Command-H) Camino and only when sending links from Perian it seems. So new steps:

1. Have two windows open in Camino, one of them minimized.
2. Hide Camino (Command-H)
3. Open an external link from Perian.

I can not get it to work if I open a bookmark saved on the desktop, nor opening a link in an email (Mail).
So it might just be a Perian bug?

Comment 5

10 years ago
Unless they use Apple Events, I can't think of how it could be different (unless you already have that link open in the minimized window).

I wouldn't be shocked if having the app hidden messes with window order in a similar way to Spaces though, so we should test that.

Comment 6

10 years ago
David mentioned on the forum that this might be some plist weirdness, too.

For posterity's sake, David, would you post the plists (both WindowState and the app's plist) on this bug? And will you also try to see if you can reproduce the problem with both those plists temporarily set aside?
(Reporter)

Comment 7

10 years ago
Files available here: http://dl.getdropbox.com/u/32952/Camino.zip

I will try out a fresh Application Support folder when I get home from University this evening.

Comment 8

10 years ago
I just tried to reproduce this on 10.5.7/Intel (Unibody MBP) with a fresh profile and the two files David posted for download in comment 7.

Using the STR in comment 0, I was unable to reproduce his problem. Instead, I got the external link opening in its own new window.

I then tried checking the first three boxes in the Tabs pref pane and again tried to reproduce the problem. I was unable to reproduce it and got a new tab in the un-minimised window. The minimised window remained in the Dock during both tests and did not try to un-minimise itself at all.

David, did you get a chance to try it with fresh plists and/or a fresh profile?

Comment 9

10 years ago
I had forgotten about comment 4 and 5 when I wrote comment 8. Oops.

I just tested this with a fresh profile and fresh app plist. Here are STR for reproducing this bug:

1) Launch Camino and set the "links opened by other applications" pref.
2) Minimise the window.
3) Open another window. (Optional: visit a different site to enable you to differentiate between this window and the other one.)
4) Hide Camino.
5) Switch to another app.
6) Open a link from an external app.

If the first window you opened after launching Camino is minimised in the Dock, it will be un-minimised and the new tab will be opened in that window.

If the first window you opened after launching Camino is *not* minimised, it doesn't matter whether you have a minimised window or not; the link will open in a new tab in the first window opened.

Somehow, the app seems to be preferring whatever the "oldest" window is, regardless of whether it's minimised or not. So if you open three windows (A, B, and C) and close the first one (A) and minimise the second (B), and then run through the STR above, you'll get a new tab in B and C will remain open in the background. Etc.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 10

10 years ago
I think what's going on here is |frontmostBrowserWindow| is doing the "wrong" thing when multiple windows are open, the app is hidden, and at least one window is minimised.

I guess what this boils down to is this question: is un-minimising the window and sticking a new tab in it ever the "right" thing to do? I tend to think a minimised window should stay that way unless I explicitly un-minimise it, but I almost never minimise anything.

The only sticky situation I foresee is if there's only one window and it's minimised. I personally would prefer a new window in that case (see above about minimised windows being sacred), but again, I'm not someone who minimises windows much.

Smokey should be by momentarily to outline what the competition does in this situation.
> The only sticky situation I foresee is if there's only one window and it's
> minimised. I personally would prefer a new window in that case (see above about
> minimised windows being sacred), but again, I'm not someone who minimises
> windows much.
> 
> Smokey should be by momentarily to outline what the competition does in this
> situation.

Safari 3.2: Unminimizes the window
Firefox 3.0: Unminimizes the window
Opera 9.3: Unminimizes the window
iCab 4.x: Unminimizes the window
OmniWeb 5.8: Opens a new window

I tend to agree with Chris that if there's only one window and it's minimized, we should open a new window with a link, though I haven't thought hard about it (I do keep some windows minimized).
(Reporter)

Comment 12

10 years ago
Erh.. Another mistake.. Vienna, not Perian.. >_<

Comment 13

10 years ago
I've seen something similar tonight, without a minimised window.
With 2 windows open: A the one opened by Camino on launch, B = front-most window. I was clicking a couple of links in NNW, and all opened in window A. NNW is set to open the links in the background. Camino was originally hidden.
When I brought Camino to the front, window B was the front-most, active window.

I've probably seen that in the past, but always attributed the issue to user mistake, esp as I don't often have more than one window open.
Revisiting this on OS X 10.6.4 with a Gecko 1.9.2 based build

1. (comment 13) opening links from an external app always open in the front-most window (the one I was last looking at, that would be window B in comment 13).

2. I can't repro the STR in comment 9 anymore.

3. comment 11 - one window open but minimised: the external link un-minimises the window and opens in a new tab.

Comment 15

8 years ago
Comment 9 is still happening for me, but if and only if Camino is hidden (as noted in comment 9 step 4). 10.6.4 and Camino 20100527002151.

cl
ha. After lots testing and talking to cl on IRC, I found a way to 100% reproduce comment 9 (with Camino2.1a gecko 1.9.2):
* Create a plain text file in Textedit and type in a url
* select url and use the Services shortcut (Cmd-Shift + U)

--> the url opens in the main / first opened (minimised) window - un-minimising the window.

Clicking a url (in linkified form) does _not_ reproduce the issue: Mail.app, textedit with a rtf doc, NNW, Neo-office doc file, dragging a .webloc to the Dock icon or dragging a url from Safari's location bar all work as expected.
You need to log in before you can comment on or make changes to this bug.