495089 - Bring customizable parameters back to amo2009 install element

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Fred Wenzel [:wenzel]]

Our old install element was called like this:

        $_install_render_options = array(
            'addonIconPath' => $addonIconPath,
            'addonName'     => $addon['Translation']['name']['string'],
            'addonId'       => $addon['Addon']['id'],
            'addonFiles'    => $version['File'],
            'addonEULA'     => $addon['Translation']['eula']['string'],
            'addonStatus'   => $addon['Addon']['status'],
            'addonType'     => $addon['Addon']['addontype_id'],
            'allPlatforms'  => $platforms,
            'compatible_apps'=> $version['Compatibility']
            );
        echo $this->renderElement('install', $_install_render_options);*/

.. with a bunch of customizable options allowing to define in detail what options to show or not, and where it got its data from.

The new one has hardly any of these parameters, and relies on a well-formed add-on array being passed in, which it then uses to extract a bunch of default values.

This led to problems on the version history page (not all old versions can just point to the latest.xpi shortcut), and similar problems may appear elsewhere (on the EULA pages, maybe?).

If this turns out to be a bigger problem in other parts of the page, we should fix this. If, however, I ran into the only issue with it, we can probably WONTFIX this.

Comment 1

[Les Orchard [:lorchard]]

Attachment: allowing for custom parameters in install eklement

Ah, that makes sense now - try this patch on for size.  Also deleted the leftover mockup markup I mentioned in bug 495090.

Comment 2

[Fred Wenzel [:wenzel]]

Comment on attachment 379920 [details] [diff] [review]
allowing for custom parameters in install eklement

Looks good to me! Of course the two parts of the patch have nothing to do with each other but I shall forgive you this once ;-)

Can you please add the valid parameters to the documentation block of the element, too? You can probably just copy most, if not all, of them from the old element's code.

After that, please go ahead and check this in.

Comment 3

[Les Orchard [:lorchard]]

Checked in r26377