495124 - Front page for Thunderbird has the ugly

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

Check out https://preview.addons.mozilla.org/en-US/thunderbird/

1)  There is that giant "To install for Thunderbird" message on every add-on.  We kinda need it but I don't know where to put it.

2) There is that weird little part of an image in the top right of each add-on listing.  Something to do with spriting I guess.  I'm including in this bug because I think it will go away when we solve #1.

Comment 1

[Dave Garrett]

(In reply to comment #0)
> 1)  There is that giant "To install for Thunderbird" message on every add-on. 
> We kinda need it but I don't know where to put it.

Why don't you create a big slideshow box up top like Firefox's page has and add it there? Seems like the most logical place for it and you'll probably want the box to have panes for recommended Thunderbird add-ons anyway.

Comment 2

[Fred Wenzel [:wenzel]]

I like the idea. There's no need to tell people on every page 10 times, if we explain it well, just once, on the front page.

Comment 3

[Justin Scott [:fligtar]]

(In reply to comment #2)
> I like the idea. There's no need to tell people on every page 10 times, if we
> explain it well, just once, on the front page.

I think there's a really good chance someone will come to AMO and land on a page that isn't the homepage, and won't see that.

Perhaps we could make some sort of overlay that pops up from the Download button when clicked? If someone right clicks on it, they already know what they're doing. If someone just clicks it, they probably don't, and maybe clicking the download button instead opens a little box that explains what to do.

Comment 4

[Wil Clouser [:clouserw]]

Now that, I like.

Comment 5

[Dave Garrett]

I like that better too.

You'll probably also want to apply this to Sunbird as well, while you're at it.

Comment 6

[Chris Howse [:chowse]]

Attachment: Installation instructions as overlays

This patch replaces the installation instructions (currently inline) with a floating overlay that appears when the user clicks the 'Download Now' button. Clicking anywhere outside this overlay once it's revealed will dismiss it.

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 380533 [details] [diff] [review]
Installation instructions as overlays

Nice work.  A few things:

New CSS should go in mozilla-main.css

The text says "Right-click the link below" but it's actually above the text.  I remember changing this to be below a long time ago. :(

If JavaScript is disabled don't show anything.

It was working well at first, but now it's showing the screen and then not blocking the click...this is hard to describe so as soon as I submit this I'll walk over and show you.

Comment 8

[Chris Howse [:chowse]]

Attachment: Take 2

- Moved CSS to mozilla-main.css
- Removed any mention of clicking from the text. It's unnecessary since the instructions doesn't appear until _after_ the button is clicked.
- With JS disabled, no instructions will appear now.
- The "blocking" behavior works when the extension links aren't dead. Will test once I have a test db set up.

Comment 9

[Wil Clouser [:clouserw]]

Just commit it so we can start testing on preview.amo where the files exist.  Two other things to fix before commit:

1) You changed the text for thunderbird but not sunbird, please change that too.

2) You're commenting a bunch of stuff out in the JS.  Just delete it - that's what code versioning is for.  (Also, commenting is hard to review in a patch because all you see is a start and end).

Thanks!

Comment 10

[Justin Scott [:fligtar]]

I don't think he has commit access.

Comment 11

[Chris Howse [:chowse]]

Attachment: Final

Requested changes made. Will commit once I have access.

Comment 12

[Wil Clouser [:clouserw]]

In RTL the alignment should be reversed (the numbers should be lined up).  Also, is there a bug you've filed to get SVN access?

Comment 13

[Chris Howse [:chowse]]

(In reply to comment #12)
> Also, is there a bug you've filed to get SVN access?
Bug 495811: https://bugzilla.mozilla.org/show_bug.cgi?id=495811

Comment 14

[Chris Howse [:chowse]]

Attachment: (Really) Final

RTL fixed. Still waiting on IT.

Comment 15

[Chris Howse [:chowse]]

r26920

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of raw gettext() strings

I'm seeing raw addons_install_in_subbird_title and addons_install_in_subbird [sic] gettext defines

Not only are they raw, they're misspelled :-(

Comment 17

[Wil Clouser [:clouserw]]

Thanks - the reason they are raw is because they are misspelled.  Fixed in r26952.

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #17)
> Thanks - the reason they are raw is because they are misspelled.  Fixed in
> r26952.

Verified FIXED -- appreciate the quick fix.