Front page for Thunderbird has the ugly

VERIFIED FIXED in 5.0.6

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: clouserw, Assigned: chowse)

Tracking

unspecified
5.0.6

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

9 years ago
Check out https://preview.addons.mozilla.org/en-US/thunderbird/

1)  There is that giant "To install for Thunderbird" message on every add-on.  We kinda need it but I don't know where to put it.

2) There is that weird little part of an image in the top right of each add-on listing.  Something to do with spriting I guess.  I'm including in this bug because I think it will go away when we solve #1.

Comment 1

9 years ago
(In reply to comment #0)
> 1)  There is that giant "To install for Thunderbird" message on every add-on. 
> We kinda need it but I don't know where to put it.

Why don't you create a big slideshow box up top like Firefox's page has and add it there? Seems like the most logical place for it and you'll probably want the box to have panes for recommended Thunderbird add-ons anyway.
I like the idea. There's no need to tell people on every page 10 times, if we explain it well, just once, on the front page.
(In reply to comment #2)
> I like the idea. There's no need to tell people on every page 10 times, if we
> explain it well, just once, on the front page.

I think there's a really good chance someone will come to AMO and land on a page that isn't the homepage, and won't see that.

Perhaps we could make some sort of overlay that pops up from the Download button when clicked? If someone right clicks on it, they already know what they're doing. If someone just clicks it, they probably don't, and maybe clicking the download button instead opens a little box that explains what to do.
(Reporter)

Comment 4

9 years ago
Now that, I like.

Comment 5

9 years ago
I like that better too.

You'll probably also want to apply this to Sunbird as well, while you're at it.
(Reporter)

Updated

9 years ago
Assignee: nobody → chowse
(Assignee)

Comment 6

9 years ago
Created attachment 380533 [details] [diff] [review]
Installation instructions as overlays

This patch replaces the installation instructions (currently inline) with a floating overlay that appears when the user clicks the 'Download Now' button. Clicking anywhere outside this overlay once it's revealed will dismiss it.
Attachment #380533 - Flags: review?(clouserw)
(Reporter)

Comment 7

9 years ago
Comment on attachment 380533 [details] [diff] [review]
Installation instructions as overlays

Nice work.  A few things:

New CSS should go in mozilla-main.css

The text says "Right-click the link below" but it's actually above the text.  I remember changing this to be below a long time ago. :(

If JavaScript is disabled don't show anything.

It was working well at first, but now it's showing the screen and then not blocking the click...this is hard to describe so as soon as I submit this I'll walk over and show you.
Attachment #380533 - Flags: review?(clouserw) → review-
(Assignee)

Comment 8

9 years ago
Created attachment 380555 [details] [diff] [review]
Take 2

- Moved CSS to mozilla-main.css
- Removed any mention of clicking from the text. It's unnecessary since the instructions doesn't appear until _after_ the button is clicked.
- With JS disabled, no instructions will appear now.
- The "blocking" behavior works when the extension links aren't dead. Will test once I have a test db set up.
Attachment #380533 - Attachment is obsolete: true
(Reporter)

Comment 9

9 years ago
Just commit it so we can start testing on preview.amo where the files exist.  Two other things to fix before commit:

1) You changed the text for thunderbird but not sunbird, please change that too.

2) You're commenting a bunch of stuff out in the JS.  Just delete it - that's what code versioning is for.  (Also, commenting is hard to review in a patch because all you see is a start and end).

Thanks!

Updated

9 years ago
Attachment #380555 - Attachment is patch: true
Attachment #380555 - Attachment mime type: application/octet-stream → text/plain
I don't think he has commit access.
(Assignee)

Comment 11

9 years ago
Created attachment 380859 [details] [diff] [review]
Final

Requested changes made. Will commit once I have access.
Attachment #380555 - Attachment is obsolete: true
(Reporter)

Comment 12

9 years ago
In RTL the alignment should be reversed (the numbers should be lined up).  Also, is there a bug you've filed to get SVN access?
(Assignee)

Comment 13

9 years ago
(In reply to comment #12)
> Also, is there a bug you've filed to get SVN access?
Bug 495811: https://bugzilla.mozilla.org/show_bug.cgi?id=495811
(Assignee)

Comment 14

9 years ago
Created attachment 380912 [details] [diff] [review]
(Really) Final

RTL fixed. Still waiting on IT.
Attachment #380859 - Attachment is obsolete: true
(Assignee)

Comment 15

9 years ago
r26920
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Created attachment 381220 [details]
Screenshot of raw gettext() strings

I'm seeing raw addons_install_in_subbird_title and addons_install_in_subbird [sic] gettext defines

Not only are they raw, they're misspelled :-(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 17

9 years ago
Thanks - the reason they are raw is because they are misspelled.  Fixed in r26952.
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
(In reply to comment #17)
> Thanks - the reason they are raw is because they are misspelled.  Fixed in
> r26952.

Verified FIXED -- appreciate the quick fix.
Status: RESOLVED → VERIFIED

Updated

9 years ago
Blocks: 497512
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.