Closed Bug 495124 Opened 13 years ago Closed 13 years ago
Front page for Thunderbird has the ugly
Check out https://preview.addons.mozilla.org/en-US/thunderbird/ 1) There is that giant "To install for Thunderbird" message on every add-on. We kinda need it but I don't know where to put it. 2) There is that weird little part of an image in the top right of each add-on listing. Something to do with spriting I guess. I'm including in this bug because I think it will go away when we solve #1.
(In reply to comment #0) > 1) There is that giant "To install for Thunderbird" message on every add-on. > We kinda need it but I don't know where to put it. Why don't you create a big slideshow box up top like Firefox's page has and add it there? Seems like the most logical place for it and you'll probably want the box to have panes for recommended Thunderbird add-ons anyway.
I like the idea. There's no need to tell people on every page 10 times, if we explain it well, just once, on the front page.
(In reply to comment #2) > I like the idea. There's no need to tell people on every page 10 times, if we > explain it well, just once, on the front page. I think there's a really good chance someone will come to AMO and land on a page that isn't the homepage, and won't see that. Perhaps we could make some sort of overlay that pops up from the Download button when clicked? If someone right clicks on it, they already know what they're doing. If someone just clicks it, they probably don't, and maybe clicking the download button instead opens a little box that explains what to do.
Now that, I like.
I like that better too. You'll probably also want to apply this to Sunbird as well, while you're at it.
This patch replaces the installation instructions (currently inline) with a floating overlay that appears when the user clicks the 'Download Now' button. Clicking anywhere outside this overlay once it's revealed will dismiss it.
Attachment #380533 - Flags: review?(clouserw)
Attachment #380533 - Flags: review?(clouserw) → review-
- Moved CSS to mozilla-main.css - Removed any mention of clicking from the text. It's unnecessary since the instructions doesn't appear until _after_ the button is clicked. - With JS disabled, no instructions will appear now. - The "blocking" behavior works when the extension links aren't dead. Will test once I have a test db set up.
Attachment #380533 - Attachment is obsolete: true
Just commit it so we can start testing on preview.amo where the files exist. Two other things to fix before commit: 1) You changed the text for thunderbird but not sunbird, please change that too. 2) You're commenting a bunch of stuff out in the JS. Just delete it - that's what code versioning is for. (Also, commenting is hard to review in a patch because all you see is a start and end). Thanks!
I don't think he has commit access.
Requested changes made. Will commit once I have access.
Attachment #380555 - Attachment is obsolete: true
In RTL the alignment should be reversed (the numbers should be lined up). Also, is there a bug you've filed to get SVN access?
(In reply to comment #12) > Also, is there a bug you've filed to get SVN access? Bug 495811: https://bugzilla.mozilla.org/show_bug.cgi?id=495811
RTL fixed. Still waiting on IT.
Attachment #380859 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I'm seeing raw addons_install_in_subbird_title and addons_install_in_subbird [sic] gettext defines Not only are they raw, they're misspelled :-(
13 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Thanks - the reason they are raw is because they are misspelled. Fixed in r26952.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
(In reply to comment #17) > Thanks - the reason they are raw is because they are misspelled. Fixed in > r26952. Verified FIXED -- appreciate the quick fix.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.