Closed Bug 495154 Opened 15 years ago Closed 15 years ago

buildbotcustom: revisit inheritance for '*UnittestBuildFactory'


(Release Engineering :: General, enhancement, P3)



(Not tracked)



(Reporter: sgautherie, Unassigned)




Bug 494676 comment 13:
From  Robert Kaiser   2009-05-26 10:46:53 PDT

the unit test
factories sucks by not knowing about mozillaDir or mozillaObjdir, which is only
defined in the MercurialBuildFactory from they should be derived in theory but
aren't in practice.
We need to either introduce it at least in
CCUnittestFactory or hardcode the "mozilla" subdir (which the other CC*Factory
implementations do by passing just that as mozillaDir to the generic ones).


There is:
class MozillaBuildFactory(BuildFactory):
class MercurialBuildFactory(MozillaBuildFactory):
class CCMercurialBuildFactory(MercurialBuildFactory):

Current state is:
class UnittestBuildFactory(MozillaBuildFactory):
class CCUnittestBuildFactory(MozillaBuildFactory):

New suggested state would be:
class UnittestBuildFactory(MercurialBuildFactory):
class CCUnittestBuildFactory(MercurialBuildFactory):

In addition or at least, we might want to look into:
class CCUnittestBuildFactory(UnittestBuildFactory):

I'll let you confirm whether I understood this right.
The target IMHO should be:

class UnittestBuildFactory(MercurialBuildFactory):
class CCUnittestBuildFactory(CCMercurialBuildFactory, UnittestBuildFactory):
Component: Project Organization → Release Engineering
Ever confirmed: true
Product: SeaMonkey →
QA Contact: organization → release
Version: Trunk → other
Just a heads up that once unittests on packaged builds are working for both optimized and debug builds, we're not going to need the UnittestBuildFactory any more.
Oh, but _we_ (at least SeaMonkey) will need it, because:

1) We have no debug build cycles enabled for other platforms than Linux due to VM shortage but don't want to lose leak numbers.
2) We can't afford to spend more machine time on testing due to VM shortage, so we can't run tests on both opt and debug builds.
3) We have no package list for Mac, so we can't enable tests on build boxes without having test files in all packages.
Component: Release Engineering → Release Engineering: Future
Priority: -- → P3
Given that we've moved away from using UnittestBuildFactory - I don't see anything getting done here. If you guys want to inherit differently, that's up to you.
Closed: 15 years ago
Resolution: --- → INCOMPLETE
Moving closed Future bugs into Release Engineering in preparation for removing the Future component.
Component: Release Engineering: Future → Release Engineering
Product: → Release Engineering
You need to log in before you can comment on or make changes to this bug.