Closed Bug 495181 Opened 14 years ago Closed 14 years ago

OS X: Remove resize mark between location bar and search bar

Categories

(Firefox :: Theme, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.6a1

People

(Reporter: faaborg, Assigned: dao)

Details

(Whiteboard: [polish-easy] [polish-visual][polish-p1])

Attachments

(1 file, 1 obsolete file)

This control is mostly visual noise, let's just remove it like we did for the other 3 themes.  Discoverability of the ability to re-size these fields (without mousing over to investigate) isn't worth the cost of a lack of minimalism, especially on OS X.
Whiteboard: [polish-easy] [polish-visual]
patch should be ui-review beltzner since I proposed the change.
Assignee: nobody → dao
Attached patch patch (obsolete) — Splinter Review
This is a bit of a mess, because the location bar and the search bar are bigger than they look. For example, -moz-margin-start: -6px should really be -4px.
Bug 482086 and bug 482105 will solve this.
Attachment #380059 - Flags: ui-review?(beltzner)
Attachment #380059 - Flags: review?(mstange)
Attachment #380059 - Flags: review?(mstange) → review+
This had already been done for the firefox 3 theme, btw. For some reason that I don't know, or for no reason, it came back with a proto update.
Do we really need this? Comment 2 and 3 make me wonder why we think it's super-important to take this for Firefox 3.5 at this time in the cycle.
(at the very least we should include the comments from comment 2 in the patch)
I'll include comment 2 before landing.
Attached patch comment addedSplinter Review
Attachment #380059 - Attachment is obsolete: true
Attachment #380703 - Flags: ui-review?(beltzner)
Attachment #380703 - Flags: approval1.9.1?
Attachment #380059 - Flags: ui-review?(beltzner)
Told Dao that we should try this on trunk, first. a=beltzner for mozilla-central only.
http://hg.mozilla.org/mozilla-central/rev/3ffd77a256b8
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Comment on attachment 380703 [details] [diff] [review]
comment added

I don't think I want to mess around with this in 191 this late in the game.

Fine to keep it on trunk, though.
Attachment #380703 - Flags: ui-review?(beltzner)
Attachment #380703 - Flags: ui-review+
Attachment #380703 - Flags: approval1.9.1?
Attachment #380703 - Flags: approval1.9.1-
This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p1]
You need to log in before you can comment on or make changes to this bug.