495181 - OS X: Remove resize mark between location bar and search bar

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

This control is mostly visual noise, let's just remove it like we did for the other 3 themes.  Discoverability of the ability to re-size these fields (without mousing over to investigate) isn't worth the cost of a lack of minimalism, especially on OS X.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

patch should be ui-review beltzner since I proposed the change.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

This is a bit of a mess, because the location bar and the search bar are bigger than they look. For example, -moz-margin-start: -6px should really be -4px.
Bug 482086 and bug 482105 will solve this.

Comment 3

[Dão Gottwald [:dao]]

This had already been done for the firefox 3 theme, btw. For some reason that I don't know, or for no reason, it came back with a proto update.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Do we really need this? Comment 2 and 3 make me wonder why we think it's super-important to take this for Firefox 3.5 at this time in the cycle.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

(at the very least we should include the comments from comment 2 in the patch)

Comment 6

[Dão Gottwald [:dao]]

I'll include comment 2 before landing.

Comment 7

[Dão Gottwald [:dao]]

Attachment: comment added

Comment 8

[Dão Gottwald [:dao]]

tryserver build:
https://build.mozilla.org/tryserver-builds/[e-mail]-bug495181/bug495181-macosx.dmg

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Told Dao that we should try this on trunk, first. a=beltzner for mozilla-central only.

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3ffd77a256b8

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 380703 [details] [diff] [review]
comment added

I don't think I want to mess around with this in 191 this late in the game.

Fine to keep it on trunk, though.

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.