[Safari 4] "Popular" tab is beneath "Editor's Picks", but should be on the same line

VERIFIED FIXED in 5.0.7

Status

P3
major
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: stephend, Assigned: jbalogh)

Tracking

unspecified
5.0.7
x86
Windows Vista

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
Created attachment 380088 [details]
Screenshot

Using Safari 4 public beta on https://preview.addons.mozilla.org/en-US/firefox/collections/popular, the "Popular" tab is beneath "Editor's Picks", and it should be on the same line as the latter.
(Assignee)

Comment 1

10 years ago
Moving to 5.0.7 in hopes that 5.0.6 will one day ship.  Safari is not a high priority for us.
Target Milestone: 5.0.6 → 5.0.7

Updated

10 years ago
Priority: -- → P3
(Assignee)

Comment 2

10 years ago
Created attachment 382194 [details] [diff] [review]
moving the listing tab's margin to li fixes safari and doesn't affect firefox
Assignee: nobody → jbalogh
Attachment #382194 - Flags: review?(rdoherty)
Comment on attachment 382194 [details] [diff] [review]
moving the listing tab's margin to li fixes safari and doesn't affect firefox

Looks good!
Attachment #382194 - Flags: review?(rdoherty) → review+
(Assignee)

Comment 4

10 years ago
stephend: how do you feel about sneaking this into 5.0.6?
(Reporter)

Comment 5

10 years ago
(In reply to comment #4)
> stephend: how do you feel about sneaking this into 5.0.6?

Land it!
(Assignee)

Comment 6

10 years ago
r27396.  

QA: The CSS affects the front-page listing, the collections listing, and anything else using that layout.  There should be no visual changes in Firefox, and less fail in Webkit.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Reporter)

Comment 7

10 years ago
Verified FIXED using Safari 4 public beta; we didn't regress Shiretoko, Firefox 3.0.10, Opera 9.64, nor IE 7/8.
Status: RESOLVED → VERIFIED
(Reporter)

Updated

9 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.