495203 - [Safari 4] "Popular" tab is beneath "Editor's Picks", but should be on the same line

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Using Safari 4 public beta on https://preview.addons.mozilla.org/en-US/firefox/collections/popular, the "Popular" tab is beneath "Editor's Picks", and it should be on the same line as the latter.

Comment 1

[Jeff Balogh (:jbalogh)]

Moving to 5.0.7 in hopes that 5.0.6 will one day ship.  Safari is not a high priority for us.

Comment 2

[Jeff Balogh (:jbalogh)]

Attachment: moving the listing tab's margin to li fixes safari and doesn't affect firefox

Comment 3

[Ryan Doherty (:rdoherty)]

Comment on attachment 382194 [details] [diff] [review]
moving the listing tab's margin to li fixes safari and doesn't affect firefox

Looks good!

Comment 4

[Jeff Balogh (:jbalogh)]

stephend: how do you feel about sneaking this into 5.0.6?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> stephend: how do you feel about sneaking this into 5.0.6?

Land it!

Comment 6

[Jeff Balogh (:jbalogh)]

r27396.  

QA: The CSS affects the front-page listing, the collections listing, and anything else using that layout.  There should be no visual changes in Firefox, and less fail in Webkit.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Safari 4 public beta; we didn't regress Shiretoko, Firefox 3.0.10, Opera 9.64, nor IE 7/8.