495224 - Builds involving symlinks in the source dir fail to find config/config.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dave Townsend [:mossop]]

Attachment: patch rev 1

I build a XUL app by symlinking its directory into the mozilla source tree, then building with --enable-application=<dir>. On 1.9.0 this worked, on 1.9.1 it fails with the following error:

gmake[6]: *** No rule to make target `../../../config/config.mk', needed by `_xpidlgen/mccoy.xpt'.  Stop.

A bisect shows bug 467050 as being the culprit. $DEPTH appears to be relative to the real source dir, so it ends up going somewhere else random on my machine to find config.mk. Neil's suggestion that topsrcdir would be better seems to work for me.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 380116 [details] [diff] [review]
patch rev 1

There's actually never a $(DEPTH)/config/config.mk AFAIK, since that'd be in the objdir. I think this is just a bug that slipped by me.

Comment 2

[Justin Wood (:Callek)]

(In reply to comment #1)
> (From update of attachment 380116 [details] [diff] [review])
> There's actually never a $(DEPTH)/config/config.mk AFAIK, since that'd be in
> the objdir. I think this is just a bug that slipped by me.

...sorry, good catch.

Comment 3

[Dave Townsend [:mossop]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/c4e00b34bbdd

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 380116 [details] [diff] [review]
patch rev 1

Would like to take this minor correction fix on branch. It doesn't really affect the Firefox build so there should be no breakage from it.

Comment 5

[Samuel Sidler (old account; do not CC)]

Comment on attachment 380116 [details] [diff] [review]
patch rev 1

Approved for 1.9.1.2. a=ss for release-drivers

Please land on mozilla-1.9.1 and use the ".2-fixed" option of the "status1.9.1" flag.

Comment 6

[Dave Townsend [:mossop]]

Fixed on 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3ae02ebabc8c