Closed
Bug 495242
Opened 15 years ago
Closed 15 years ago
cmd_close shouldn't be passed through the controllers for menu options
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
4.31 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
In the 3 pane window, call DefaultController.supportsCommand("cmd_close") and you'll always get true returned. Same for the standalone window. It is never used in the hiddenWindow (menu_close is disabled).
Therefore we should stop pretending it can be disabled, and just call the different functions we need directly.
I need this for bug 493700 where we're redoing the controllers, and if someone decides not to implement a controller or all of it, then the user won't be able to close a tab or window via the menu at least...
Attachment #380143 -
Flags: review?(philringnalda)
|
||
Updated•15 years ago
|
Attachment #380143 -
Flags: review?(philringnalda) → review+
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 380143 [details] [diff] [review] The fix Seems reasonable.
|
Assignee | |
Comment 2•15 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/1b3663fa364e
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•