Closed
Bug 495243
Opened 15 years ago
Closed 15 years ago
Refresh secure icons on OS X
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
People
(Reporter: faaborg, Unassigned)
Details
(Keywords: verified1.9.1, Whiteboard: [icon-shiretoko][icon-complete])
Attachments
(3 files)
665 bytes,
image/png
|
beltzner
:
approval1.9.1+
|
Details |
405 bytes,
image/png
|
beltzner
:
approval1.9.1+
|
Details |
609 bytes,
image/png
|
beltzner
:
approval1.9.1+
|
Details |
This a pure icon job just to add a little more visual polish to the OS X theme.
Reporter | ||
Comment 1•15 years ago
|
||
File drop for /source/browser/themes/pinstripe/browser/
Reporter | ||
Comment 2•15 years ago
|
||
File drop for /source/browser/themes/pinstripe/browser/
Reporter | ||
Comment 3•15 years ago
|
||
File drop for /source/browser/themes/pinstripe/browser/
Reporter | ||
Updated•15 years ago
|
Whiteboard: [icon-shiretoko][icon-complete]
Updated•15 years ago
|
Attachment #380150 -
Flags: approval1.9.1?
Updated•15 years ago
|
Attachment #380151 -
Flags: approval1.9.1?
Updated•15 years ago
|
Attachment #380149 -
Flags: approval1.9.1?
Comment 4•15 years ago
|
||
Comment on attachment 380149 [details]
Secure-Glyph-White.png
a191=beltzner
Attachment #380149 -
Flags: approval1.9.1? → approval1.9.1+
Updated•15 years ago
|
Attachment #380150 -
Flags: approval1.9.1? → approval1.9.1+
Updated•15 years ago
|
Attachment #380151 -
Flags: approval1.9.1? → approval1.9.1+
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6b5508397a29
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Comment 6•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/02714cc003e6
Keywords: fixed1.9.1
Comment 7•15 years ago
|
||
This seems to be one of two changes in the range for a mac-only Talos memory usage regression. The memory used went up by about 700KB. See the "Talos Regression: Tp3 (Private Bytes) increase 0.82% on Tiger Firefox" mail in m.d.tree-management. Are these icons really so much bigger when decoded than the old ones? Or are they triggering some sort of memory leak?
Comment 8•15 years ago
|
||
Nope, they shouldn't be that much bigger. Did it happen on both 1.9.1 and mozilla-central?
Comment 9•15 years ago
|
||
The only mail so far is for m-c, but note that it's been 3 days since the checkin and the mail just came... So it might just be that on 1.9.1 the increase was entirely under the script's threshold. You should probably look at the actual graph data for both to see what's going on.
Reporter | ||
Comment 10•15 years ago
|
||
Aside from the pixels being different this was purely a file replacement. If this did trigger a memory leak it would be very interesting to understand how that happened.
Comment 11•15 years ago
|
||
I think the regression report is bogus. If you look at the graph for the data, the values are very unstable. In any case, I think it's extremely unlikely the image replacements would cause something like this. (pngcheck confirms they're just plain old images, no color profiles or the like).
Comment 12•15 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2pre) Gecko/20090727 Shiretoko/3.5.2pre ID:20090727031954 and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090727 Minefield/3.6a1pre ID:20090727031437
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•