Closed
Bug 495285
Opened 16 years ago
Closed 16 years ago
Only show the "Go" button for the "Other languages" select widget when JavaScript is disabled
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.7
People
(Reporter: stephend, Assigned: jbalogh)
References
()
Details
Attachments
(1 file)
|
3.67 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
For consistency's sake, I'd like to see the same fix in bug 495207 applied to the "Other languages" <select> in the footer.
(Specifically, we should only see the "Go" button when JavaScript is disabled, and it should continue to load the selected locale's URL using onchange().)
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → jbalogh
|
||
Updated•16 years ago
|
Target Milestone: --- → 5.0.7
|
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #382624 -
Flags: review?(clouserw)
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 382624 [details] [diff] [review]
removing Go buttons when we have js and form.go
This is nicely done. Good work.
QA: this affects the language selector in the footer and the dropdown in the bug mentioned in comment 0.
Attachment #382624 -
Flags: review?(clouserw) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
|
Reporter | |
Comment 4•16 years ago
|
||
Verified FIXED -- tested with JS disabled and enabled.
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Updated•16 years ago
|
Keywords: push-needed
|
||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•