Closed
Bug 495341
Opened 15 years ago
Closed 15 years ago
js mime emitter fails to properly detect attachments in IMAP URIs
Categories
(MailNews Core :: MIME, defect)
MailNews Core
MIME
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: davida, Assigned: davida)
References
Details
Attachments
(1 file)
|
554 bytes,
patch
|
asuth
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
The regex _partRE forgot to double-escape the ?, which means that the regular expression interpreted it as an operator, rather than the literal question mark it is. The reason the test suite passed is that the URIs it generates have other arguments before the "part" in their URIs, while for IMAP URIs the part is the first thing after the question mark. It's also why it's not practical to add a test for this fix.
Flags: blocking-thunderbird3+
Attachment #380298 -
Flags: review?(bugmail)
|
Assignee | |
Updated•15 years ago
|
Attachment #380298 -
Flags: superreview?(bienvenu)
|
||
Updated•15 years ago
|
Attachment #380298 -
Flags: review?(bugmail) → review+
|
|
||
Comment 1•15 years ago
|
||
Once sid0's changes land for 466227 we'll have the test support to be able to run this against IMAP folders and get those URLs we so crave.
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Updated•15 years ago
|
Attachment #380298 -
Flags: superreview?(bienvenu) → superreview+
|
||
Comment 2•15 years ago
|
||
http://build.mozillamessaging.com/mercurial/comm-central/rev/d5ea5077b996
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
Version: unspecified → Trunk
|
|
||
Updated•11 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•