Make search category drop down look prettier

VERIFIED FIXED in 5.0.6

Status

addons.mozilla.org Graveyard
Collections
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: fligtar, Assigned: fligtar)

Tracking

unspecified
5.0.6

Details

Attachments

(7 attachments)

(Assignee)

Description

9 years ago
Created attachment 380302 [details] [diff] [review]
patch, v1

With "all add-ons" and "all collections" in the dropdown, I think we should make them stand out a bit more. This patch does that.
Attachment #380302 - Flags: review?(clouserw)
Comment on attachment 380302 [details] [diff] [review]
patch, v1

better than what we got - thanks
Attachment #380302 - Flags: review?(clouserw) → review+
(Assignee)

Comment 2

9 years ago
r26534. I don't know if I have to run the build script for CSS to update on preview and oh god how did this get in here I am not good with computers
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Created attachment 380356 [details]
Post-fix screenshot
Verified FIXED.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 5

9 years ago
Re-opening my prettiness bug. It turns out Firefox is the only browser that doesn't display an optgroup label if it's blank. The other browers leave a blank line, and it's invalid html to not have a label. So, need to add 2 labels or get rid of the optgroups. I'll probably go with the latter.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

9 years ago
Created attachment 381189 [details] [diff] [review]
new patch

Patch to fix for all browsers.
Attachment #381189 - Flags: review?(clouserw)
Attachment #381189 - Flags: review?(clouserw) → review+
(Assignee)

Comment 7

9 years ago
Thanks, r26961
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
Created attachment 381240 [details]
Screenshot of Opera 9.64
Created attachment 381241 [details]
Screenshot of IE 8 in IE 7 mode
Created attachment 381243 [details]
Screenshot of Safari 3.2.3
Created attachment 381244 [details]
Screenshot of Google Chrome
All of the above, just to be able to say "Verified FIXED" with more confidence :-)
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.