495351 - collections view page only shows current application add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

The collections view page should show all add-ons regardless of application but right now it's only showing add-ons for the current app.

To reproduce:

1) Create a new collection.
2) Add some add-ons for firefox and some for thunderbird
3) Look at the view page.  It'll say "$total add-ons in this collection" but will only show the ones for the app you're browsing.
4) Change the url to thunderbird, see the rest of your add-ons.

Comment 1

[Fred Wenzel [:wenzel]]

If you want this fixed for 5.0.6, we *will* have to fix bug 431707 along with it.

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This removes the "current app only" requirement for showing collection content.

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 380511 [details] [diff] [review]
Patch, rev. 1

this fixes the problem but then we've got "Add to firefox" on the label of the buttons even if they aren't for firefox

Comment 4

[Wil Clouser [:clouserw]]

Attachment: button fix

what do you think of this?

Comment 5

[Fred Wenzel [:wenzel]]

Comment on attachment 380536 [details] [diff] [review]
button fix

I like it. (I was already going to ask why the install button element doesn't take care of this itself).

I'll commit your patch along with the others.

Comment 6

[Fred Wenzel [:wenzel]]

Fixed add-on model in r26644, fixed install button in r26645.

Comment 7

[krupa raj[:krupa]]

steps to reproduce:
1.Create a collection with firefox addons+thunderbird addons
2.check the list of addons in View Collection page
3.Add the theme "Thunderbird Tangerine" to the collection
4.Repeat step#2

observed behavior:
Thunderbird Tangerine was not listed in the View collection page

screencast:
http://screencast.com/t/zEcvsWRQmTW

Comment 8

[Wil Clouser [:clouserw]]

The good news:  Adding Thunderbird & Firefox themes works as expected. (try "aero thunderbird")

The bad news:  Thunderbird Tangerine is an incomplete add-on and shouldn't appear in the suggestion box or be allowed to be added to the collection.

Comment 9

[Fred Wenzel [:wenzel]]

Krupa filed a bug for this: bug 496449.

Comment 10

[krupa raj[:krupa]]

verified

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"