Refactor test cases to check enough runs

RESOLVED FIXED

Status

--
trivial
RESOLVED FIXED
10 years ago
11 months ago

People

(Reporter: bradh, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.10) Gecko/2009042708 Fedora/3.0.10-1.fc9 Firefox/3.0.10
Build Identifier: 

We have a lot of code in the input_end() functions that looks like:
  if (r.testsRun != 1) {
    print("Error: must be 1 tests run, instead ran " + r.testsRun);
  } else {
    r.list();
  }

It would be nice to factor that out.

Reproducible: Always
(Reporter)

Updated

10 years ago
Blocks: 484865
(Reporter)

Comment 1

10 years ago
Created attachment 380403 [details] [diff] [review]
refactoring of duplicated code

Also throws in a few newlines on the end of files that missed them.
Attachment #380403 - Flags: review?(tglek)

Updated

10 years ago
Attachment #380403 - Flags: review?(tglek) → review?(dmandelin)
Attachment #380403 - Flags: review?(dmandelin) → review+
Comment on attachment 380403 [details] [diff] [review]
refactoring of duplicated code

Good idea.

Comment 3

10 years ago
http://hg.mozilla.org/users/tglek_mozilla.com/dehydra-gcc/rev/54fabccc5a49
Status: UNCONFIRMED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

11 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.