495454 - tab strip loses + button when you have 4 tabs and fennec is in full screen mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

on the N810 there are two modes: regular and full screen.

When adding tabs, you can add 4 tabs for a given tab strip.  There is always a + button at the bottom of the tab strip.  When you have 4 tabs and go to add another, the + button is not visible when you are in regular mode.  switching to full screen shows the button.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava, want to just switch to 3 tabs per column? and keep the nice big thumbnails

Comment 2

[Madhava Enros [:madhava]]

always or just in small mode?  I think we mean to open full screen by default in the future, btw.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I am fine with adjusting to 3 for non full screen.  But it is very easy for the user to switch in/out of full screen mode, so we don't want to remove functionality when they toggle.

Comment 5

[Aakash Desai [:aakashd]]

The + Tabbutton is cut off even in full screen mode, so I think adjusting it to 3 for both modes is going to be necessary to resolve:fixed this bug.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch (fixes full screen)

This patch uses the 2/3 aspect ratio of the n810 to change the size of the thumbnails to 64px x 106px - which is enough to see the 4 tabs and the "+" button in fullscreen.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/ea3086b832fd

this only fixes the fullscreen case. filing a followup bug to handle the general case.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

filed bug 511493

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED On build:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090921
Fennec/1.0b4pre