Closed Bug 495471 Opened 13 years ago Closed 13 years ago

Easy to lose access to canvas from first-start screen

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(fennec1.0b2+)

RESOLVED FIXED
Tracking Status
fennec 1.0b2+ ---

People

(Reporter: bcombee, Assigned: pavlov)

Details

Attachments

(2 files)

Attached image Screenshot
1) Start Fennec on desktop
2) Do a few drags from left-to-right and right to left to verify panning and display of the toolbars.
3) Sometimes, on a right-to-left drag, you'll end up with the canvas entirely off screen and the navigation toolbar on the left side overlapping the tab bar.
Flags: wanted-fennec1.0?
Is this with kinetic scrolling enabled? If so, try it with kinetic turned off.
Yes, this is after the patch that reenabled it... I'll turn off in the code and retest.
OK, I turned off kinetic in the code and wasn't able to reproduce the problem.  I suspect that we're getting some off-the-scale horizontal numbers somehow that aren't working.  I'll add logging into the pan code to try to capture what happened, maybe add an assert if the x coord of the toolbar panel goes below a certain threshhold.
tracking-fennec: --- → ?
Attached patch fixSplinter Review
in some cases we're ending up with mouse events being added with the same timestamp, which results in us doing a divide-by-0 in our averaging code, which ends up with NaN speeds and lots of fail
Assignee: nobody → pavlov
tracking-fennec: ? → 1.0b2+
Attachment #380817 - Attachment is patch: true
Attachment #380817 - Attachment mime type: application/octet-stream → text/plain
Attachment #380817 - Flags: review?(mark.finkle)
Attachment #380817 - Flags: review?(mark.finkle) → review+
Attachment #380817 - Flags: review+
Comment on attachment 380817 [details] [diff] [review]
fix

This patch fixed this bug... looked at the code and it seems fine to me.
http://hg.mozilla.org/mobile-browser/rev/e573f70ac662
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.