495518 - Search Tools category landing page needs AMO2009/ClearLeft style

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Garrett]

The Search Tools category landing page hasn't been spiffed up with the AMO2009/ClearLeft style yet.

Comment 1

[Wil Clouser [:clouserw]]

This page and the theme landing page both use this layout and they are not impressive.  /me thinks

Comment 2

[Wil Clouser [:clouserw]]

Attachment: design idea

Throwing the header/footer around this page is not easy and the content doesn't match up to any of the styles clearleft has.

I played around for the last hour trying to fit things in and came up with the attached (I've got HTML ready for this right now if y'all like it).  It could use minor tweaking (I don't know why the left column starts so low) but I think overall it's an improvement over what's live right now.

It has the benefit of supporting more than just recommended add-ons using the same layout as the front page (we can add tabs for popular, newest, etc.).

For the record, the current site chooses 2 recommended add-ons and 2 random add-ons to show.  This design just grabs 4 recommended add-ons from the pool.

Comment 3

[Nick Nguyen [:osunick]]

That is SO MUCH BETTER.  Ship it.

Comment 4

[Justin Scott [:fligtar]]

I like it

Comment 5

[Dave Garrett]

Looks nice, but needs a "Search Tools" red text header to match the other category pages.

I think this would all look/feel better if the search plugins weren't conflated with search extensions and were separated onto their own page, but that's a bit out of the scope of a reskin.

Comment 6

[Wil Clouser [:clouserw]]

Attachment: style the page

Comment 7

[Wil Clouser [:clouserw]]

(In reply to comment #5)
> Looks nice, but needs a "Search Tools" red text header to match the other
> category pages.

It's a link so it's a different color.

> I think this would all look/feel better if the search plugins weren't conflated
> with search extensions and were separated onto their own page, but that's a bit
> out of the scope of a reskin.

Yep.  It's mediocre at best and wrong at worst (we tell people they can't install them without JS).

Comment 8

[Wil Clouser [:clouserw]]

Comment on attachment 381538 [details] [diff] [review]
style the page

Guess I didn't catch wenzel in time.

Comment 9

[Ryan Doherty (:rdoherty)]

Comment on attachment 381538 [details] [diff] [review]
style the page

This looks pretty good. 

To remove the extra padding at the top of the sidebar:

.secondary h3 {
margin-top:0;
}

(could affect other things, will need to check or make it more specific)

If we remove the margin:1em for .prose, it would help the 'Additional Resources' module.

I also think giving the entire category list ul the class .highlight would help. (might need to tweak padding)

These are all nitpicks, overall it looks pretty good.

Comment 10

[Wil Clouser [:clouserw]]

Changes made and committed in r27146.  Thanks.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

I filed bug 496424 about the "too beaucoup" scaling.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.