495528 - Buildbot - enable haltOnFailure for initial compile steps

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Chris Peyer]

The default buildbot failure mode is 

flunkOnFailure: when True, a FAILURE of this build step will mark the overall build as a FAILURE. The remaining steps will still be executed. 

The compile steps before actual compilation happens should be changed to

haltOnFailure: if True, a FAILURE of this build step will cause the build to halt immediately. Steps with alwaysRun=True are still run.

(see buildbot docs: http://djmitche.github.com/buildbot/docs/0.7.10/#Common-Parameters)

This way, if any of the repo syncing steps fail, a compile will not even be attempted. (steps: sync_clean, sync_clone, sync_update, BB_SLAVEUpdate)

Additionaly, haltOnFailure could be enabled for the download_testmedia step in the smoke phase, though that might not be needed because the media will be compiled even if the test media is not downloaded.

Comment 1

[Brent Baker]

+1, and we should haltOnFailure the "download_testmedia" if it fails. That script will attempt to get the zip file (precompiled test media) and if that fails it will then compile all of the test files locally... So if that actually fails then we should stop the build since the acceptance scripts will also be unable to properly compile the test media.

Comment 2

[Brent Baker]

Attachment: haltOnFailure

haltOnFailure: Source_Clean, Source_Clone, Source_Clone(Sandbox), Source_Update, Download_AS_testcases, BB_SLAVEUpdate

alwaysRun: Util_ZombieKiller

Comment 3

[Chris Peyer]

Comment on attachment 380806 [details] [diff] [review]
haltOnFailure

Looks good.

Comment 4

[Brent Baker]

Pushed as 1972:845e52adf001