Closed Bug 495542 Opened 11 years ago Closed 11 years ago

make building w/o wireless tools a error

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

right now, you can get into a silent failure state where the netwerk/wifi code isn't compiled because the host machine doesn't have wireless-tools installed.  Then when you go to use geolocation using the network geolocation provider, nothing happens (well, we return an error to content saying that the location isn't available).

We should make it so that building without network/wifi support fails loudly -- and have an option to build without it.
Assignee: nobody → doug.turner
Attachment #380525 - Flags: review?(ted.mielczarek)
Comment on attachment 380525 [details] [diff] [review]
warning to error...

+    AC_MSG_ERROR([Necko WiFi scanning not supported on your platform.])

r=me, but please make the error message specify whatever --disable-foo you can use to work around this.
Attachment #380525 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/45d3e6f95292
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Doug, can you keep it with Windows, Linux, Mac?

We don't have wifi support libraries on Solaris.
Hi Ginn,

It is unfortunate that Solaris doesn't have wifi tools because geolocation (which uses wifi scanning) is a core feature of Firefox 3.5.  Is there really no way to implement these interfaces on Solaris?

Doug
We don't have libiw on Solaris.

I'll check if we've alternative API for wifi scanning on Solaris.
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Likewise for BSDs
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.