495607 - JavaScript text stopped rotating in latest versions of Firefox.

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[d]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1pre) Gecko/20090529 Shiretoko/3.5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1pre) Gecko/20090529 Shiretoko/3.5pre

On http://mrdoob.com/projects/chromeexperiments/ball_pool the text in the big ball rotates nicely in Firefox 3.5 Beta 4. However, it does not in the latest trunk build of Shiretoko, nor the latest Minefield.

Reproducible: Always

Steps to Reproduce:
1. Visit http://mrdoob.com/projects/chromeexperiments/ball_pool
2. Throw the big ball around.
3. Does the text rotate in the latest versions of Firefox?
Actual Results:  
The text isn't rotating at all.

Expected Results:  
The text is rotating along the "rolling" of the ball.

Comment 1

[Steve England [:stevee]]

Can you please double-check that the text in the big ball rotates in Firefox 3.5beta4? I just tested a pre-beta4 build and the text didn't rotate in that either.

Comment 2

[d]

Yes, it "still" rotates nicely in the 3.5 Beta 4. I looked a bit at the behavior and it might be the case that none of the balls are actually spinning, that is as in, it's not just the text not rotating. It seemed to be the case when I compared it to Google Chrome.

Comment 3

[Steve England [:stevee]]

Hmm, I don't see the text rotating in Firefox 3.5b4, Firefox 3.5pre, nor Opera 9.64. I guess what would help this bug is two things:

1) A minimized testcase.. that is to say, the least amount of JS and HTML required to show the bug.

2) A regression range from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/ testing with the builds ending in "-mozilla-1.9.1"

Comment 4

[d]

Well, I'm lacking the knowledge to extract/create that kind of testcase, but that sounds like a good idea. To add to it, I'm running Windows Vista, what OS are you running, as I think that might affect it?

Comment 5

[d]

Attachment: Shows the text (or ball) rotating in Firefox 3.5 Beta 4.

Comment 6

[Sylvain Pasche]

The issue is about useragent sniffing:

if (/Firefox[\/\s](\d+\.\d+)/.test(navigator.userAgent))

If you go to about:config and set the general.useragent.extra.firefox preference to something like Firefox/3.5, the ball is spinning again.

I've sent a mail to the demo author about this.

Comment 7

[d]

Oh, I see. It only supports versions with the version number system, as in 3.5. Not when you use Beta or Pre...?

Thank you for sending a mail, anyway.

Comment 8

[d]

Sorry, a follow-up. Why would the rotation need to be affected depending on which User-Agent you have?

Comment 9

[d]

Triple post...

I guess it is because they use Shiretoko and Minefield, and not Firefox in the User-agent then?

Comment 10

[Sylvain Pasche]

(In reply to comment #9)
> Triple post...
> 
> I guess it is because they use Shiretoko and Minefield, and not Firefox in the
> User-agent then?

Right. It's looking at the user agent in order to set the webkit-transform /
MozTransform vendor specific CSS properties.

Looking more at the code, it should be possible to avoid all kind of sniffing
by simply setting both the Webkit and Gecko CSS properties in all cases. I'll
tell the author about it.

Comment 11

[Sylvain Pasche]

This should be fixed already.

And we may also have the text aligned in the main ball soon on Firefox, stay tuned ;-)

Comment 12

[d]

Looking good, nice work :)

I'll change it from invalid to fixed, as the text and rotation was still a bit of a problem ;)

Comment 13

[d]

Sorry, I don't want to ruin the fun, but the text is vibrating quite a lot (especially compared to Google Chrome). Should this be seen as a bug, and should I file a new one, or should we keep it in this bug?

Comment 14

[Sylvain Pasche]

Please file a new bug, recycling existing bugs is not always a good idea. Maybe there's already a bug filled for this, if you have time you can try to look for it.

By the way, this bug should be marked as INVALID, because it's not an issue with Firefox and not fix was checked into the tree (see https://bugzilla.mozilla.org/page.cgi?id=fields.html#resolution). Thanks.

Comment 15

[d]

https://bugzilla.mozilla.org/show_bug.cgi?id=495802

Posted.