Typo creates extremely deep CSS selector

VERIFIED FIXED

Status

SeaMonkey
UI Design
P1
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: John Morrison, Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3+], URL)

(Reporter)

Description

18 years ago
Decided to make it a bug report so we don't forget this one.

A comma was left out, making two three-deep child selectors into a six-deep
descendant selector. That would take a few cycles.

treeitem[type="http://home.netscape.com/NC-rdf#Folder"][open="true"]
     > treerow > .treecell-bookmark
treeitem[type="http://home.netscape.com/NC-rdf#IEFavoriteFolder"][open="true"]
     > treerow > .treecell-bookmark
{
list-style-image:
   url("chrome://communicator/skin/bookmarks/bookmark-folder-open.gif");
}
(Reporter)

Comment 1

18 years ago
Nominating nsbeta3. Descendant CSS selectors are known to have big performance
penalties, particularly in <tree> widgets.
Keywords: nsbeta3, perf
QA Contact: sairuh → jrgm
(Reporter)

Comment 2

18 years ago
Might as well note that at ~line 103 in the same file, there are adjacent
child selectors (i.e., 'foo > > bar'). I have no idea what that would try 
to match, but it can't be right.

treeitem[type="http://home.netscape.com/NC-rdf#Folder"][id="NC:PersonalToolb
arFolder"][open="true"] > > treerow > .treecell-bookmark
{
list-style-image: url("chrome://communicator/skin/bookmarks/personal-folder-
open.gif");
}
treeitem[selected="true"][type="http://home.netscape.com/NC-rdf#Folder"][id=
"NC:PersonalToolbarFolder"][open="true"] > > treerow > .treecell-bookmark
{
list-style-image: url("chrome://communicator/skin/bookmarks/personal-folder-
open-sel.gif");
}
 
p.s., I realize that we now have three skins in the tree; the above can be found 
in both the modern and blue (the skin formerly known as modern).

Updated

18 years ago
Priority: P3 → P1
Whiteboard: [nsbeta3+]

Comment 3

18 years ago
Nav triage team: nsbeta3+, P1
fixed. 
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

18 years ago
(Okay, this may be annoying, but ...) Your checkin didn't include the two 
instances where there are 'foo > > bar' selectors, which may also equate to 
really deep descendant selectors.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
got it this time.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

18 years ago
Yes, indeed
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.