49561 - Typo creates extremely deep CSS selector

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[John Morrison]

Decided to make it a bug report so we don't forget this one.

A comma was left out, making two three-deep child selectors into a six-deep
descendant selector. That would take a few cycles.

treeitem[type="http://home.netscape.com/NC-rdf#Folder"][open="true"]
     > treerow > .treecell-bookmark
treeitem[type="http://home.netscape.com/NC-rdf#IEFavoriteFolder"][open="true"]
     > treerow > .treecell-bookmark
{
list-style-image:
   url("chrome://communicator/skin/bookmarks/bookmark-folder-open.gif");
}

Comment 1

[John Morrison]

Nominating nsbeta3. Descendant CSS selectors are known to have big performance
penalties, particularly in <tree> widgets.

Comment 2

[John Morrison]

Might as well note that at ~line 103 in the same file, there are adjacent
child selectors (i.e., 'foo > > bar'). I have no idea what that would try 
to match, but it can't be right.

treeitem[type="http://home.netscape.com/NC-rdf#Folder"][id="NC:PersonalToolb
arFolder"][open="true"] > > treerow > .treecell-bookmark
{
list-style-image: url("chrome://communicator/skin/bookmarks/personal-folder-
open.gif");
}
treeitem[selected="true"][type="http://home.netscape.com/NC-rdf#Folder"][id=
"NC:PersonalToolbarFolder"][open="true"] > > treerow > .treecell-bookmark
{
list-style-image: url("chrome://communicator/skin/bookmarks/personal-folder-
open-sel.gif");
}
 
p.s., I realize that we now have three skins in the tree; the above can be found 
in both the modern and blue (the skin formerly known as modern).

Comment 3

[verah (gone)]

Nav triage team: nsbeta3+, P1

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

fixed. 

Comment 5

[John Morrison]

(Okay, this may be annoying, but ...) Your checkin didn't include the two 
instances where there are 'foo > > bar' selectors, which may also equate to 
really deep descendant selectors.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

got it this time.

Comment 7

[John Morrison]

Yes, indeed