495624 - accessibility shouldn't be caching the current focus

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Neil Deakin]

From bug 178324, it should instead be retrieved from the focus manager when needed. A cached value is likely to be inaccurate.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Why don't we use nsDocument::GetActiveElement?

Note Enn comments in our code:

NS_IMETHODIMP nsDocAccessible::GetFocusedChild(nsIAccessible **aFocusedChild)
{
  // XXXndeakin P3 accessibility shouldn't be caching the focus

In any event we should investigate when our cached node is different from what
this API gives us. For cases it should be the same we should add test coverage.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> Why don't we use nsDocument::GetActiveElement?

> In any event we should investigate when our cached node is different from what
> this API gives us. 

Yep, it's different, for example, menuitems and etc. I don't have clever idea how we could combine gecko cached focused node with our rules.

Comment 4

[alexander :surkov (:asurkov)]

Also we cache frame type of the focused node, it's kind of related with cached focused node.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Yeah I keep mid air colliding with you :)

Note we also store:
PRUint32 nsDocAccessible::gLastFocusedAccessiblesState
nsIAtom *nsDocAccessible::gLastFocusedFrameType

We probably need a hybrid of storing what we thought the last focus state was, and asking what currently the focus state is.

Comment 6

[alexander :surkov (:asurkov)]

fixed by bug 673958