accessibility shouldn't be caching the current focus

RESOLVED FIXED in mozilla10

Status

()

Core
Disability Access APIs
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Neil Deakin (not available until Aug 9), Assigned: surkov)

Tracking

(Blocks: 1 bug, {access})

Trunk
mozilla10
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

From bug 178324, it should instead be retrieved from the focus manager when needed. A cached value is likely to be inaccurate.
Summary: accessibility shouldn't be cached the current focus → accessibility shouldn't be caching the current focus
Depends on: 178324

Updated

8 years ago
Keywords: access
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

8 years ago
Blocks: 389800
Why don't we use nsDocument::GetActiveElement?

Note Enn comments in our code:

NS_IMETHODIMP nsDocAccessible::GetFocusedChild(nsIAccessible **aFocusedChild)
{
  // XXXndeakin P3 accessibility shouldn't be caching the focus

In any event we should investigate when our cached node is different from what
this API gives us. For cases it should be the same we should add test coverage.

Updated

7 years ago
Duplicate of this bug: 545436
(Assignee)

Comment 3

7 years ago
(In reply to comment #1)
> Why don't we use nsDocument::GetActiveElement?

> In any event we should investigate when our cached node is different from what
> this API gives us. 

Yep, it's different, for example, menuitems and etc. I don't have clever idea how we could combine gecko cached focused node with our rules.
(Assignee)

Comment 4

7 years ago
Also we cache frame type of the focused node, it's kind of related with cached focused node.
Yeah I keep mid air colliding with you :)

Note we also store:
PRUint32 nsDocAccessible::gLastFocusedAccessiblesState
nsIAtom *nsDocAccessible::gLastFocusedFrameType

We probably need a hybrid of storing what we thought the last focus state was, and asking what currently the focus state is.
(Assignee)

Comment 6

6 years ago
fixed by bug 673958
Assignee: nobody → surkov.alexander
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.