495686 - OS selection color is no longer respected.

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Shawn Wilsher :sdwilsh]

Because bug 458199 uses images as a background, the OS selection color is no longer respected.

In the past we said we weren't going to do this type of thing (see bug 391916).

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Shawn, thanks for bringing this to my attention. Please back out and re-open bug 458199 in order to resolve this bug (a=beltzner); I had assumed that it would respect the OS selection colour (since Markus has been attentive to that in the past) 

In other news, I'm really-really going to stop taking theme changes around now. I have been burned too many times to count in this release cycle. The trust is gone.

Comment 2

[Markus Stange [:mstange]]

We no longer respect the selection color, now we respect the "appearance" color, i.e. blue / graphite. I thought that was fine, too, but it looks like I was wrong.
I'll back out.
Bug 391916 is interesting.

Comment 3

[Markus Stange [:mstange]]

Backed out on trunk and branch.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Thanks Markus - trust is gone was a little harsh, it was just my second or third UI regression in a row :(

In the future, we should get some discussion and feedback going before we make these polish changes. My fail as much as anyone's.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking verified based on code backout.