49569 - add or improve title of tests in webshell/tests/viewer/samples

Status: RESOLVED WORKSFORME

(Core Graveyard :: Tracking, defect, P3)

Description

[Andreas J. Koenig]

BUILD: today's CVS

It's sometimes hard to keep in mind which test was crashing. Especially as
several tests have the same title and other have no title at all. Introducing a
title to all tests definitely helps.

I used these two perl oneliners to add a title to all tests (run from within the
samples directory):

# add empty title:
perl -0777 -i -pe 'next if /<title/i;s!(<head\s*?>)!$1\n<title></title>!gim;'
*.html

# improve title with filename:
perl -0777 -i -pe 's!(<title>)(.*?</title>)!$1$ARGV: $2!im;' *.html

I'll attach the resulting diff in case you like a diff more than a program.

BTW: The reason why I'd like to see this patch in is because running all tests
more than once leads to a crash with current build. I'd like to reduce the time
needed to reproduce the crash reliably.

Comment 1

[Andreas J. Koenig]

Attachment: Add a title where there is none, add filename to title

Comment 2

[Andreas J. Koenig]

AS a followup to my remark about current crashes: the crashes apparently can not
be reproduced with the tests. I had something broken in my ~/.mozilla/
directory. Removing the whole directory helped. I still need to find out what it
was, but it seems "it" is not related to the tests.

Comment 3

[leger]

rick, who can fix this?

Comment 4

[Doron Rosenberg (IBM)]

reproter: has this been improved?

Comment 5

[Andreas J. Koenig]

Nothing has changed. For the record, the files are in
webshell/tests/viewer/samples/. The 4 most recent files there have a timestamp
of Sept 14, all others are older than my report.

Comment 6

[Keyser Sose]

Marking as NEW as per reporters comments.

Comment 7

[chris hofmann]

rpotts?

Comment 8

[Phil Ringnalda (:philor)]

Go go gadget passage-of-time: they're all dead now.