Chat tags should follow same conventions as tikiwiki freetags

RESOLVED FIXED in 1.3

Status

support.mozilla.org Graveyard
Chat
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: zzxc, Assigned: zzxc)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
The current tag implementation from bug 471004 allows tags with whitespace and with uppercase characters.  This should be changed to match the conventions for tikiwiki tags.  (All whitespace should be stripped, and all tags should be converted to lowercase)

This will reduce the number of duplicate tags we have, such as "user experience", "User experience", "ux", and "userexperience".  Duplicates that are not matches of each other (ux, userexperience) are being configured in the metrics script to count as one tag.
(Assignee)

Updated

9 years ago
Assignee: nobody → bugs

Updated

9 years ago
Target Milestone: 1.2 → 1.3
(Assignee)

Comment 1

9 years ago
Created attachment 386171 [details] [diff] [review]
Patch v1

This forces all tags to conform to TikiWiki conventions, as well as makes the input format more flexible.  Flags at the end of a tag (such as /tag ux?) are now recognized, and the code is cleaned up to make changing the flag types in the future simple.
Attachment #386171 - Flags: review?(ozten.bugs)

Updated

9 years ago
Attachment #386171 - Flags: review?(ozten.bugs) → review+

Comment 2

9 years ago
Comment on attachment 386171 [details] [diff] [review]
Patch v1

I'm having a hard time understanding the data that goes into Userrequest.java line 525 and the nested for loop. Maybe add a comment with example inputs.

Patch looks good. r+
(Assignee)

Comment 3

9 years ago
in r50365
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Component: Chat → Chat
Product: support.mozilla.org → support.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.