495776 - [Linux] xpcshell-tests: test_sendBackground.js (and others) fails intermittently with "TypeError: real is undefined"

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Serge Gautherie (:sgautherie)]

{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1243829692.1243834323.8072.gz
Linux comm-central unit test on 2009/05/31 21:14:52

TEST-UNEXPECTED-FAIL | /builds/slave/comm-central-linux-unittest/build/objdir/mozilla/_tests/xpcshell/test_compose/unit/test_sendBackground.js | test failed (with xpcshell return code: 0), see following log:
*** TEST-UNEXPECTED-FAIL | /builds/slave/comm-central-linux-unittest/build/objdir/mozilla/_tests/xpcshell/test_compose/unit/test_sendBackground.js | TypeError: real is undefined
}

Comment 1

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1243855744.1243860578.20646.gz
Linux comm-central unit test on 2009/06/01 04:29:04

Comment 2

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1243893654.1243894020.31190.gz
Linux comm-central check on 2009/06/01 15:00:54

Comment 3

[Serge Gautherie (:sgautherie)]

Fwiw,
{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/1243957402.1243962956.32062.gz&fulltext=1
OS X 10.5 comm-1.9.1 unit test on 2009/06/02 08:43:22

TEST-UNEXPECTED-FAIL | /builds/slave/comm-1.9.1-macosx-unittest/build/objdir/mozilla/_tests/xpcshell/test_compose/unit/test_sendBackground.js | test failed (with xpcshell return code: -8), see following log:
  >>>>>>>
  ### XPCOM_MEM_LEAK_LOG defined -- logging leaks to /var/folders/lM/lMjnsUOwEnGg5M72PZ3JSk+++TM/-Tmp-/runxpcshelltests_leaks.log
Directory request for: CurWorkD that we (mailDirService.js) are not handling, leaving it to another handler.
*** test pending
Directory request for: MailD that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: MFCaF that we (mailDirService.js) are not handling, leaving it to another handler.
Directory request for: DefRt that we (mailDirService.js) are not handling, leaving it to another handler.

  <<<<<<<
}

I don't know whether this box is bad behaving, or if it's a side-effect of bug 495527 landing.

Comment 4

[Serge Gautherie (:sgautherie)]

Previous reports were failing at "test_sendBackground.js :: anonymous :: line 63".

*****

{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1244169209.1244173910.17753.gz
Linux comm-central unit test on 2009/06/04 19:33:29

[...]
TEST-PASS | /builds/slave/comm-central-linux-unittest/build/objdir/mozilla/_tests/xpcshell/test_compose/unit/test_sendBackground.js | [anonymous : 53] false == false
TEST-UNEXPECTED-FAIL | /builds/slave/comm-central-linux-unittest/build/objdir/mozilla/_tests/xpcshell/test_compose/unit/test_sendBackground.js | TypeError: real is undefined - See following stack:
JS frame :: /builds/slave/comm-central-linux-unittest/build/mozilla/testing/xpcshell/head.js :: do_throw :: line 134
JS frame :: /builds/slave/comm-central-linux-unittest/build/objdir/mozilla/_tests/xpcshell/test_compose/unit/test_sendBackground.js :: anonymous :: line 70
}

Actually, the failing check is
55       do_check_transaction(transaction,
because 'transaction' is undefined...

Comment 5

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1244624381.1244624821.20598.gz
Linux comm-central check on 2009/06/10 01:59:41

Comment 6

[Serge Gautherie (:sgautherie)]

Same case with other tests:

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1244524272.1244525281.2300.gz
Linux comm-central check on 2009/06/08 22:11:12
test_compose/unit/test_bug474774.js | [anonymous : 54] false == false
test_compose/unit/test_bug474774.js :: anonymous :: line 68

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1244559829.1244561061.5509.gz
Linux comm-central check on 2009/06/09 08:03:49
test_compose/unit/test_sendMessageLater.js | [anonymous : 64] false == false
test_compose/unit/test_sendMessageLater.js :: anonymous :: line 77

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> OS X 10.5 comm-1.9.1 unit test on 2009/06/02 08:43:22

Just ignore this unstable SeaMonkey-Ports box ftb.

*****

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1244638160.1244642768.11086.gz
Linux comm-central unit test on 2009/06/10 05:49:20

Comment 8

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1244738982.1244743609.12854.gz
Linux comm-central unit test on 2009/06/11 09:49:42
test_bug474774.js :: anonymous :: line 68

Comment 9

[Mark Banner (:standard8)]

Yeah, I don't think we need any more logs especially when they are all saying pretty much the same thing.

Comment 10

[Mark Banner (:standard8)]

Attachment: The fix

I've finally realised what this is. The check_transaction function is being passed a null value - the transaction is being assigned via .playTransaction just after performTest is being called, however we're in the callback here. So if everything goes just right, the callback gets called before we've hit the playTransaction call an check_transaction gets an undefined value.

Not sure why we aren't seeing this more often and on the other tests that do this but I'm updating them all to just pass the result of server.playTransaction when they need it.

Comment 11

[David :Bienvenu]

Comment on attachment 391861 [details] [diff] [review]
The fix

sorry for the delay - tests succeed w/ this patch for me on windows...

Comment 12

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/d773b790cb3f