Update Policy on Getting Commit Access re employers

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mitchell, Assigned: mitchell)

Tracking

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Remove the "Not your employer" requirement for the people sponsoring CVS access.  Address the concern over "group-think" by making sure the super-reviewer will have a fresh perspective.  See discussions in .governance starting 2/4/09 by robert o'callahan and by me on 5/21/09.

Comment 1

9 years ago
Created attachment 381575 [details]
Updated version of Becoming A Mozilla Committer page

Attached is an updated version of the Becoming A Mozilla Committer page.  I tried to also do a diff, but the changes were different enough that it showed the whole page as being new.  I can take another pass at that and see if I can get something that shows the differences.
(Assignee)

Comment 2

9 years ago
In case a diff remains hard, here are  the main areas that have changed: 

1.  the introductory paragraphs before the "STOP" notice
2.  the "General Rule"  -- changes SR criteria by removing "different module" language and replacing with "must not have previously reviewed your patches" and ads rationale; removes the "not your employer" requirement
3.  "Modules Not Associated with . . . "  This has changed to be clear that Calendar will now need SR OK for commit access, and then Calendar-focused contributors are full-fledged contributors to comm-central.
4.  Revoking Accounts section added
5.  Dormant Accounts section added

Comment 3

9 years ago
Created attachment 381600 [details] [diff] [review]
Patch for Becoming A Mozilla Committer page showing differences with current version

I cleaned up the formatting of the page and generated a diff of the changes.
s/moz-central/mozilla-central/g

Comment 5

9 years ago
Comment on attachment 381600 [details] [diff] [review]
Patch for Becoming A Mozilla Committer page showing differences with current version

>+    project-wide requirements. Fore example, we might decide that each repository should

s/Fore/For/
(Assignee)

Comment 6

9 years ago
Revised language for initial section on dormant accounts.  We'll start with this and make the rest of the revised policy official while we figure out the best mechanism -- see discussion on .governance of the last ew days


Dormant Accounts:

As of June 2009 we're working on a plan for addressing accounts that have seen no activity for some specified period of time.  We may disable such accounts.  Assuming we do this,  the process for reactivating them will be a much more lightweight process than that for obtaining commit access the first time.

Comment 7

9 years ago
Created attachment 382303 [details] [diff] [review]
Patch for Becoming A Mozilla Committer page showing differences with current version

Attached is a new patch that addresses the last three comments.
Attachment #381600 - Attachment is obsolete: true

Updated

9 years ago
Attachment #382303 - Attachment is patch: true
Attachment #382303 - Attachment mime type: application/octet-stream → text/plain
Because people are like that, the question of whether "The super-reviewer must not have previously reviewed your patches" actually means "super-reviewed" or "reviewed or super-reviewed" is going to come up.
(Assignee)

Comment 9

9 years ago
Phil

yes you're right, probably best to be clear about this.

Comment 10

9 years ago
Re comment #8, is there a suggestion for new text to use for that sentence?
(Assignee)

Comment 11

9 years ago
phil's language seems right:

change "previously reviewed your patches" to "previously reviewed OR SUPER-REVIEWED" your patches

[caps are for emphasis, not for the final doc]

Comment 12

9 years ago
OK, I made this change and checked in the update.  It should be live on the site in about 15 or 20 minutes.  Closing as fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 13

9 years ago
agh, found another typo, where "moz-central" should be "mozilla-central"

Logistics

For those in a hurry, here's a list of the steps that need to happen to become a Mozilla committer to the moz-central
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 14

9 years ago
OK, this has been fixed and checked in.
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.