495878 - Remove duplication in collection search and collection listing

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Jeff Balogh (:jbalogh)]

This is handled in collection_controller:_listingSorting() and _listing() now.

Comment 1

[Scott McCammon [:mccammos]]

Jeff,

Sorting works for me on the search page, however eliminating the duplicate code in the search controller and view is very desirable.

I can move _listingSorting() and all but rendering in _listing() into a new component called CollectionsListing. Then search controller can take advantage of the shared code.

For the view code, the only major differences are: h2 header, tabs/no tabs, and extra query params for the sort form.

Do you think it would be better to factor out a handful of common elements, or simply mix in a couple of special checks for search in collections/listing.thtml?

Comment 2

[Jeff Balogh (:jbalogh)]

I prefer small building blocks, so I would go with pulling together a few elements than trying to cram it all into one heap.  And the component sounds sweet!

I was only looking at the initial diff, not the current code, which didn't have working sorting.

Comment 3

[Scott McCammon [:mccammos]]

Attachment: patch v1

This is an improvement, though there is still a lot of view overlap due to container elements.

The patch also brings search up to date with the recent jqModal requirement.

Comment 4

[Jeff Balogh (:jbalogh)]

Comment on attachment 381675 [details] [diff] [review]
patch v1

Looks good, though you may want to change the contributors & copyright date on the licenses.

Comment 5

[Scott McCammon [:mccammos]]

r27193

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"