49588 - MLK: si_CheckGetData() leaves little droppings laying around in memory

Status: VERIFIED FIXED

(SeaMonkey :: Passwords & Permissions, defect, P3)

Description

[Bruce Mitchener]

si_CheckGetData() leaks like this:

         MLK: 28 bytes leaked in 2 blocks
         This memory was allocated from:
               malloc         [rtlib.o]
               PR_Malloc      [prmem.c:38]
               nsMemoryImpl::Alloc(unsigned int) [nsMemoryImpl.cpp:106]
               nsMemory::Alloc(unsigned int) [nsMemoryImpl.cpp:233]
               nsCppSharedAllocator<unsigned short>::allocate(unsigned int,const void*) [nsCppSharedAllocator.h:72]
               nsCRT::strndup(const unsigned short*,unsigned int) [nsCRT.cpp:497]
               nsCRT::strdup(const unsigned short*) [nsCRT.cpp:490]
               nsString::ToNewUnicode()const [nsString2.cpp:790]
               Wallet_Localize [wallet.cpp:686]
               si_CheckGetData(unsigned short**,const unsigned short*,const unsigned short*,nsIPrompt*,unsigned int,int*) [singsign.cpp:455]
                    PRInt32 buttonPressed = 1; /* in case user exits dialog by clickin X */
                    PRUnichar * prompt_string = (PRUnichar*)dialogTitle;
                    if (dialogTitle == nsnull || nsCRT::strlen(dialogTitle) == 0)
               =>     prompt_string = Wallet_Localize("PromptForData");
                    PRUnichar * check_string;
                    if (savePassword != SINGSIGN_SAVE_PASSWORD_PERMANENTLY) {
                      check_string = nsnull;
               SINGSIGN_Prompt [singsign.cpp:2367]
               nsSingleSignOnPrompt::Prompt(const unsigned short*,const unsigned short*,const unsigned short*,unsigned int,const unsigned short*,unsigned short**,int*) [nsWalletService.cpp:454]
               GlobalWindowImpl::Prompt(JSContext*,long*,unsigned int,long*) [nsGlobalWindow.cpp:1385]
               WindowPrompt(JSContext*,JSObject*,unsigned int,long*,long*) [nsJSWindow.cpp:1259]
               js_Invoke      [jsinterp.c:716]
               js_Interpret   [jsinterp.c:2517]
               js_Execute     [jsinterp.c:887]
               JS_EvaluateUCScriptForPrincipals [jsapi.c:2770]
               nsJSContext::EvaluateString(const nsString&,void*,nsIPrincipal*,const char*,unsigned int,const char*,nsString&,int*) [nsJSEnvironment.cpp:525]
               nsEvaluateStringProxy::EvaluateString(char**,int*) [nsJSProtocolHandler.cpp:167]
               *unknown func* [pc=0xfef893dc]
               EventHandler(PLEvent*) [nsProxyEvent.cpp:505]
               PL_HandleEvent [plevent.c:587]
               PL_ProcessPendingEvents [plevent.c:528]
               nsEventQueueImpl::ProcessPendingEvents() [nsEventQueue.cpp:356]
         Block of 14 bytes (2 times); last block at 0x2053b30

the problem is that the case in which it allocates the memory is not the same as the
case in which it is kind enough to delete it.

I got this by doing a javascript:url=prompt('blah');location.href=url; thing.

Comment 1

[Stephen P. Morse]

Fix checked in.

Comment 2

[sairuh (rarely reading bugmail)]

backend fix. rubberstamp vrfy.