Our download buttons make me sad

VERIFIED FIXED in 5.0.6

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: clouserw, Assigned: clouserw)

Tracking

unspecified
5.0.6

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 380967 [details] [diff] [review]
lessfugly.patch

They look _so_ bad.  Now, I'm not drunk so I'm not going to carry on about them but I do think we are taking a step backwards with the new design, and not just on the edge cases[1].  Just browse around the site and be underwhelmed.

[1] https://preview.addons.mozilla.org/en-US/firefox/addon/7431 - This used to say "Add to firefox" in a frozen button.  Now it just says "An older version may work" - it's not even a button.  May work for what?

------------------

Anyway, I'm not a designer but I've got a patch that at least will let me sleep at night.  What do you guys think of this?  I'm not looking to fix all of it's problems - I'm looking to drop this into the 5.0.6 release so we can actually tell our friends that we work on AMO without pretending comcast is down when they ask to see it.
Attachment #380967 - Flags: review?(fwenzel)
(Assignee)

Comment 1

9 years ago
Created attachment 380968 [details]
Example screenshots
Not to denigrate the issue, but it seems there are significant differences in rendering borders on Linux. The border around the download button area is definitely 2x as wide as it should be.

And for those people that don't have an AMO instance running, can you add a screenshot of the new button style?
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> Not to denigrate the issue, but it seems there are significant differences in
> rendering borders on Linux. The border around the download button area is
> definitely 2x as wide as it should be.
> 
> And for those people that don't have an AMO instance running, can you add a
> screenshot of the new button style?

I made that border bigger because the button sticks out of the top of the current one - you just can't tell with it's current colors (on linux.  to be fair, I'm also still seeing http://www.pict.com/view/695161/0/sdfg so ymmv).</offtopic>
(Assignee)

Updated

9 years ago
Attachment #380967 - Flags: review?(fwenzel) → review?(rdoherty)
Comment on attachment 380967 [details] [diff] [review]
lessfugly.patch

I like the new design. 

Only problem I saw was if an add-on is recommended, for older versions of Firefox AND shows up under the 'popular' tab on the homepage, the button is a different style than on the add-on's display page (will attach screenshot).
Attachment #380967 - Flags: review?(rdoherty) → review-
Created attachment 381097 [details]
button differences
(Assignee)

Comment 6

9 years ago
Created attachment 381105 [details] [diff] [review]
v2
Attachment #380967 - Attachment is obsolete: true
Attachment #381105 - Flags: review?(rdoherty)
Comment on attachment 381105 [details] [diff] [review]
v2

Lookin' pretty hot!
Attachment #381105 - Flags: review?(rdoherty) → review+

Comment 8

9 years ago
clouserw+++ - definitely much improved.
(Assignee)

Comment 9

9 years ago
Thanks, r27014
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED -- they're no longer sad-making, and I've filed a couple bugs on how they look in IE, which is minor.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.