495914 - Advanced search drawer appears on homepage load, then disappears

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Nick Nguyen [:osunick]]

The advanced search drawer displays for at least half a second and then disappears.  It's pretty distracting, any way we can keep this from happening?

Comment 1

[Nick Nguyen [:osunick]]

Ryan suggested a solution which is based on what we do for AMO today.  Always hide this drawer, but for JS disabled, have the tab link to the homepage with a param like advancedsearch=true that reloads the page with it open.

Comment 2

[Ryan Doherty (:rdoherty)]

Attachment: v1

quick and dirty method

Comment 3

[Fred Wenzel [:wenzel]]

Comment on attachment 381191 [details] [diff] [review]
v1

Works well, MINUS the line:
->>>>>>> bug 495386: reskin category landing pages:site/app/webroot/css/amo2009/main-mozilla.css

I hope that was just hanging around in your working dir, not in the tree.

Comment 4

[Les Orchard [:lorchard]]

That was my bad - I fixed it in r26944

One thing I was going to ask about this patch (which works), is why you used a beforeFilter in lots of controllers instead of maybe an if(!empty($_GET['advanced'])) in just the search element?

Comment 5

[Ryan Doherty (:rdoherty)]

(In reply to comment #4)
> That was my bad - I fixed it in r26944
> 
> One thing I was going to ask about this patch (which works), is why you used a
> beforeFilter in lots of controllers instead of maybe an
> if(!empty($_GET['advanced'])) in just the search element?

I toyed with this idea, but it felt kinda 'dirty', ie, the search element behavior is explicitly tied to $_GET parameters, instead of the controller telling it when to show/hide. Maybe I was being too strict. 

I had to add the function to all the beforeFilters in the controllers because there is no way to globally add it to all them. Most controllers override just about everything app_controller.php sets up.

Comment 6

[Ryan Doherty (:rdoherty)]

r27002

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to comment #5)
> I had to add the function to all the beforeFilters in the controllers because
> there is no way to globally add it to all them. Most controllers override just
> about everything app_controller.php sets up.

That's certainly out of scope here, but I think every controller that overrides beforeFilter() should also call its parent's beforeFilter(). I think it does make sense to have a place where we can put global stuff like this, and app_controller seems to be the right one.

Comment 8

[Fred Wenzel [:wenzel]]

(In reply to comment #7)
> That's certainly out of scope here...

Bug 496133.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- tested JS disabled, too.