Closed Bug 495919 Opened 15 years ago Closed 15 years ago

Add ids to preferences elements to allow extensions to overlay them easily

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file)

Attached patch patch rev 1Splinter Review
Trying to add new preferences to the Thunderbird options is a pain because the <preferences> elements have no ids. This patch adds them to the main panes.
Attachment #381023 - Flags: review?(philringnalda)
I tried to figure out the pattern of interCaps and CamelCase, to see if you were following it correctly, but maybe it was too early in the morning, and I was completely unable to grasp just what the pattern was. WTF *are* we doing?
(In reply to comment #1)
> I tried to figure out the pattern of interCaps and CamelCase, to see if you
> were following it correctly, but maybe it was too early in the morning, and I
> was completely unable to grasp just what the pattern was. WTF *are* we doing?

I tried to follow what appeared to be the prevalent style in each XUL (based mostly on the prefpane elements), though it looks like I slipped up in connection.xul
Comment on attachment 381023 [details] [diff] [review]
patch rev 1

Yeah, let's pretend it somehow makes sense, change connection and r=me.
Attachment #381023 - Flags: review?(philringnalda) → review+
Pushed: http://hg.mozilla.org/comm-central/rev/ea48ca4f2084
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
The pushed patch has an XUL-typo:

> <preferences is="composePreferences">

'is=....' must be 'id=......'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fixed
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
Assignee: nobody → dtownsend
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: