Closed
Bug 495919
Opened 15 years ago
Closed 15 years ago
Add ids to preferences elements to allow extensions to overlay them easily
Categories
(Thunderbird :: Preferences, defect)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: mossop, Assigned: mossop)
Details
Attachments
(1 file)
14.21 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
Trying to add new preferences to the Thunderbird options is a pain because the <preferences> elements have no ids. This patch adds them to the main panes.
Attachment #381023 -
Flags: review?(philringnalda)
Comment 1•15 years ago
|
||
I tried to figure out the pattern of interCaps and CamelCase, to see if you were following it correctly, but maybe it was too early in the morning, and I was completely unable to grasp just what the pattern was. WTF *are* we doing?
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1) > I tried to figure out the pattern of interCaps and CamelCase, to see if you > were following it correctly, but maybe it was too early in the morning, and I > was completely unable to grasp just what the pattern was. WTF *are* we doing? I tried to follow what appeared to be the prevalent style in each XUL (based mostly on the prefpane elements), though it looks like I slipped up in connection.xul
Comment 3•15 years ago
|
||
Comment on attachment 381023 [details] [diff] [review] patch rev 1 Yeah, let's pretend it somehow makes sense, change connection and r=me.
Attachment #381023 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 4•15 years ago
|
||
Pushed: http://hg.mozilla.org/comm-central/rev/ea48ca4f2084
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
The pushed patch has an XUL-typo:
> <preferences is="composePreferences">
'is=....' must be 'id=......'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•15 years ago
|
||
Fixed
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → dtownsend
Assignee | ||
Updated•15 years ago
|
Target Milestone: --- → Thunderbird 3.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•