495924 - TabTracker wrongly assumes that "this" pointer will be set correctly for event handlers

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Wladimir Palant]

I see the following JavaScript strict warning in Error Console with trunk Weave build (the actual exception is probably swallowed somewhere):

Warning: reference to undefined property this._log
Source File: file:///.../extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/engines/tabs.js
Line: 422

This is coming from the following line in onTabOpened:

    this._log.trace("Tab opened.");

I am not sure what value "this" pointer gets for this event, it might be the tab that was opened or the tab container or the window. It will certainly not be the TabTracker object however, hence this._log is not defined. There is Utils.bind2() method, it should be used here - for this and for the other two event handlers.

Comment 1

[Wladimir Palant]

Attachment: Proposed patch

Comment 2

[Dan Mills [:thunder]]

Comment on attachment 381032 [details] [diff] [review]
Proposed patch

r=thunder

Comment 3

[Dan Mills [:thunder]]

Pushed:

http://hg.mozilla.org/labs/weave/rev/9da82b316800

Thanks!