495928 - "Add release notes" button is not shown when uploading a new file to an existing version

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Dave Townsend [:mossop]]

After uploading a new file I am told that I can add release notes by clicking the button below, but there is no button below.

Comment 1

[Dave Townsend [:mossop]]

Attachment: screenshot

Comment 2

[Wil Clouser [:clouserw]]

Wenzel, can you investigate this?  Dave - were you doing anything special here?  Does it happen every time?

Comment 3

[Dave Townsend [:mossop]]

Just uploading a new file. Happened all of the 3 or 4 times that I did it

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: wfm

Hm, I just tried it out a few times and could not reproduce. Is this a problem occurring with some sort of malformed add-on? Or maybe a specific add-on type? I was uploading an extension.

Finally, is the button present in the DOM tree yet hidden by something? Or is it gone altogether?

Comment 5

[Dave Townsend [:mossop]]

I'm not sure if it happened when creating a new version, perhaps only when uploading a new file for a version

Comment 6

[Fred Wenzel [:wenzel]]

(In reply to comment #5)
> I'm not sure if it happened when creating a new version, perhaps only when
> uploading a new file for a version

Correct, good catch, Dave, I was able reproduce the bug!

Comment 7

[Fred Wenzel [:wenzel]]

Judging by the code, the button is not supposed to be there, so the string is broken. I'll fix it by adjusting the string.

Comment 8

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Some new string goodness. Why the href was supposed to be part of the sprintf, I don't know, and of course it was broken all along. Oh, the target URLs were broken too.

Comment 9

[Wil Clouser [:clouserw]]

Comment on attachment 383825 [details] [diff] [review]
Patch, rev. 1

It's alright with minor tweaking on this:

+"View your new file in the <a href=\"%1$s\">Versions and Files page</a>, "
+"check out your add-on's <a href=\"%2$s\">current status</a>."

s/file in the/file on the/

and add an "or" after the comma.  Stephend would know if the comma should come out altogether.

Comment 10

[Fred Wenzel [:wenzel]]

Committed to r28262. Thanks.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/developers/versions/add/9331 (my own test A9.xml search-engine add-on/plugin).