Building WeaveCrypto.dll fails if Mercurial revision doesn't start with a number

RESOLVED FIXED in 0.4

Status

Cloud Services
General
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Wladimir Palant, Assigned: Wladimir Palant)

Tracking

unspecified
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Weave build is currently failing on Windows with the following message:

WeaveCrypto.rc(65) : error RC2237 : numeric value expected at ed503656afa4

WeaveCrypto.rc(66) : error RC2237 : numeric value expected at ed503656afa4

The two lines in question are:

FILEVERSION    VER_PRODUCTVERSION
PRODUCTVERSION VER_PRODUCTVERSION

With the constants defined above:

#define VER_FILEVERSION 1,9,0,200906021553-ed503656afa4
#define VER_PRODUCTVERSION 1,9,0,200906021553-ed503656afa4

Note that the wrong constant is apparently being used for FILEVERSION. Also, the numerical constants don't match the corresponding string constants which say "1.9pre".
(Assignee)

Comment 1

9 years ago
Created attachment 381086 [details] [diff] [review]
Proposed patch

Added builid_short variable that contains only the date part of the build ID and hence can be used for FileVersion and ProductVersion fields. The full build ID is still visible in the BuildID field.
Assignee: nobody → trev.moz
Status: NEW → ASSIGNED
Attachment #381086 - Flags: review?(thunder)

Updated

9 years ago
Attachment #381086 - Flags: review?(thunder) → review+

Comment 2

9 years ago
Comment on attachment 381086 [details] [diff] [review]
Proposed patch

Thanks for catching this - we changed the buildid, and this was an unintended consequence.

Comment 3

9 years ago
Committed:

http://hg.mozilla.org/labs/weave/rev/3f6b9295c665
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: Weave → General
Product: Mozilla Labs → Weave
Target Milestone: -- → ---
Version: Trunk → unspecified
QA Contact: weave → general

Updated

9 years ago
Target Milestone: --- → 0.4
You need to log in before you can comment on or make changes to this bug.