Weave build is currently failing on Windows with the following message: WeaveCrypto.rc(65) : error RC2237 : numeric value expected at ed503656afa4 WeaveCrypto.rc(66) : error RC2237 : numeric value expected at ed503656afa4 The two lines in question are: FILEVERSION VER_PRODUCTVERSION PRODUCTVERSION VER_PRODUCTVERSION With the constants defined above: #define VER_FILEVERSION 1,9,0,200906021553-ed503656afa4 #define VER_PRODUCTVERSION 1,9,0,200906021553-ed503656afa4 Note that the wrong constant is apparently being used for FILEVERSION. Also, the numerical constants don't match the corresponding string constants which say "1.9pre".
Created attachment 381086 [details] [diff] [review] Proposed patch Added builid_short variable that contains only the date part of the build ID and hence can be used for FileVersion and ProductVersion fields. The full build ID is still visible in the BuildID field.
Assignee: nobody → trev.moz
Status: NEW → ASSIGNED
Attachment #381086 - Flags: review?(thunder)
Comment on attachment 381086 [details] [diff] [review] Proposed patch Thanks for catching this - we changed the buildid, and this was an unintended consequence.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Component: Weave → General
Product: Mozilla Labs → Weave
Target Milestone: -- → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.