Consider whether nsSVGSwitchFrame::UpdateCoveredRegion should update all children

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: jwatt, Assigned: longsonr)

Tracking

({perf})

unspecified
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Currently, nsSVGSwitchFrame::UpdateCoveredRegion updates all it's children when it calls nsSVGSwitchFrameBase::UpdateCoveredRegion(). For the purposes of drawing it should only be necessary to update the current child which would be a perf win.

Then again, maybe getBoundingClientRect() should always return something sane for *all* children?
(Assignee)

Comment 1

9 years ago
Created attachment 418997 [details] [diff] [review]
patch
Assignee: nobody → longsonr
Attachment #418997 - Flags: review?(jwatt)
(Assignee)

Updated

9 years ago
Attachment #418997 - Flags: review?(jwatt) → review?(roc)
(Assignee)

Comment 2

9 years ago
pushed http://hg.mozilla.org/mozilla-central/rev/1a3d81ba980a

Marking in-testsuite+ as existing SVG reftests should exercise this code.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.