Closed Bug 495968 Opened 12 years ago Closed 12 years ago

Consider whether nsSVGSwitchFrame::UpdateCoveredRegion should update all children

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jwatt, Assigned: longsonr)

Details

(Keywords: perf)

Attachments

(1 file)

Currently, nsSVGSwitchFrame::UpdateCoveredRegion updates all it's children when it calls nsSVGSwitchFrameBase::UpdateCoveredRegion(). For the purposes of drawing it should only be necessary to update the current child which would be a perf win.

Then again, maybe getBoundingClientRect() should always return something sane for *all* children?
Attached patch patchSplinter Review
Assignee: nobody → longsonr
Attachment #418997 - Flags: review?(jwatt)
Attachment #418997 - Flags: review?(jwatt) → review?(roc)
pushed http://hg.mozilla.org/mozilla-central/rev/1a3d81ba980a

Marking in-testsuite+ as existing SVG reftests should exercise this code.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.