Weave JAR file shouldn't be compressed

RESOLVED FIXED in 0.4

Status

Cloud Services
General
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Wladimir Palant (for Adblock Plus info Cc bugzilla@adblockplus.org), Assigned: Wladimir Palant (for Adblock Plus info Cc bugzilla@adblockplus.org))

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Weave currently uses maximum compression for its JAR file. This has a negative effect on the overall compression of the XPI package (142 kB difference though that's mostly because all the 2.5 MB jQuery are currently included). It also has a negative effect on the application performance, retrieving files from an uncompressed JAR file is faster.
Created attachment 381098 [details] [diff] [review]
Proposed patch
Assignee: nobody → trev.moz
Status: NEW → ASSIGNED
Attachment #381098 - Flags: review?(thunder)

Comment 2

9 years ago
The full jQuery was very much a mistake, I backed it out.  But more to the point--if compression is unwanted, why are JARs desired at all?  Why not bypass the JAR altogether and just ship the files as they are in the XPI?
I think, reading from a single file tends to be faster than reading from a dozen files (less seek operations on the disk, better use of OS caching).

Comment 4

9 years ago
Comment on attachment 381098 [details] [diff] [review]
Proposed patch

Ok, r=thunder
Attachment #381098 - Flags: review?(thunder) → review+

Updated

9 years ago
Keywords: checkin-needed
Target Milestone: -- → 0.4
Forgot to mention that using a JAR file makes the installation quite a bit faster :)

Updated

9 years ago
Component: Weave → General
Product: Mozilla Labs → Weave
Version: Trunk → unspecified
QA Contact: weave → general

Comment 6

9 years ago
http://hg.mozilla.org/labs/weave/rev/f8efc7c13729
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Comment 7

9 years ago
... and uses less OS file handles...
You need to log in before you can comment on or make changes to this bug.