Closed
Bug 495969
Opened 15 years ago
Closed 15 years ago
Weave JAR file shouldn't be compressed
Categories
(Cloud Services :: General, defect)
Cloud Services
General
Tracking
(Not tracked)
RESOLVED
FIXED
0.4
People
(Reporter: jwkbugzilla, Assigned: jwkbugzilla)
Details
Attachments
(1 file)
656 bytes,
patch
|
hello
:
review+
|
Details | Diff | Splinter Review |
Weave currently uses maximum compression for its JAR file. This has a negative effect on the overall compression of the XPI package (142 kB difference though that's mostly because all the 2.5 MB jQuery are currently included). It also has a negative effect on the application performance, retrieving files from an uncompressed JAR file is faster.
Assignee | ||
Comment 1•15 years ago
|
||
Comment 2•15 years ago
|
||
The full jQuery was very much a mistake, I backed it out. But more to the point--if compression is unwanted, why are JARs desired at all? Why not bypass the JAR altogether and just ship the files as they are in the XPI?
Assignee | ||
Comment 3•15 years ago
|
||
I think, reading from a single file tends to be faster than reading from a dozen files (less seek operations on the disk, better use of OS caching).
Comment 4•15 years ago
|
||
Comment on attachment 381098 [details] [diff] [review] Proposed patch Ok, r=thunder
Attachment #381098 -
Flags: review?(thunder) → review+
Updated•15 years ago
|
Keywords: checkin-needed
Target Milestone: -- → 0.4
Assignee | ||
Comment 5•15 years ago
|
||
Forgot to mention that using a JAR file makes the installation quite a bit faster :)
Updated•15 years ago
|
Component: Weave → General
Product: Mozilla Labs → Weave
Version: Trunk → unspecified
Updated•15 years ago
|
QA Contact: weave → general
Comment 6•15 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/f8efc7c13729
Comment 7•15 years ago
|
||
... and uses less OS file handles...
You need to log in
before you can comment on or make changes to this bug.
Description
•