Closed Bug 495982 Opened 15 years ago Closed 15 years ago

nsDataObjCollection::EnumFormatEtc leaks CEnumFormatEtc

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Seno.Aiko, Assigned: Seno.Aiko)

Details

(Keywords: memory-leak)

Attachments

(1 file)

This is a sibling of bug 414482. nsDataObjCollection::EnumFormatEtc has the same problem nsDataObj::EnumFormatEtc had before it was fixed, it addref's the already addrefed new enumerator.
Attachment #381110 - Flags: superreview?(roc)
Attachment #381110 - Flags: review?(roc)
Attachment #381110 - Flags: superreview?(roc)
Attachment #381110 - Flags: superreview+
Attachment #381110 - Flags: review?(roc)
Attachment #381110 - Flags: review+
Flags: blocking1.9.1?
Why would you block 1.9.1 for this?
Comment on attachment 381110 [details] [diff] [review]
rewrite EnumFormatEtc

Simple safe leak fix; can go in for a dot-release too if preferred.
Attachment #381110 - Flags: approval1.9.1?
Flags: wanted1.9.1.x?
Flags: blocking1.9.1?
Flags: blocking1.9.1-
(Go ahead and land this on trunk for baking ...)
Pushed http://hg.mozilla.org/mozilla-central/rev/f9a4ddfdd7fc
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Attachment #381110 - Flags: approval1.9.1?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: