495999 - Paused download label shown in status bar when leaving PB with active downloads

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Sylvain Pasche]

STR:
 1. Start Private Browsing
 2. Start one download that is large enough so that you can stop PB with the download still being active.
 3. Stop PB with the download still active.
Result:
 "One paused download" label is visible in the status bar, but there is no paused download if you open the Downloads window.
Expected:
 No such label should be visible, the downloads are apparently canceled when leaving PB.

Comment 1

[Aaron Train [:aaronmt]]

Confirmed in latest branch and trunk

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090602 Shiretoko/3.5pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090602 Minefield/3.6a1pre

Comment 2

[Aaron Train [:aaronmt]]

Nominating for blocker (new feature + tossing it on the radar)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

I don't that this blocks 3.5 but what would be interesting is this a regression? I think we haven't seen this in the past.

Comment 4

[Marcia Knous [:marcia]]

I haven't seen this previously, so my hunch is it might be...

(In reply to comment #3)
> I don't that this blocks 3.5 but what would be interesting is this a
> regression? I think we haven't seen this in the past.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Regression range would help, then. Whimboo was right; not blocking release.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Ehsan, it looks like that this really happens since the beginning. Don't we clear out the statusbar yet?

Comment 7

[(no longer active)]

Yeah, this is most certainly not a regression, because I don't remember fixing it at all in the first place!  ;-)

Taking, patch forthcoming.

Comment 8

[(no longer active)]

Attachment: Patch (without tests yet)

Comment 9

[(no longer active)]

Attachment: Patch + test

Same patch code-wise, but this time with a test.

Comment 10

[Samuel Sidler (old account; do not CC)]

Is mconnor still the right reviewer here?

Comment 11

[(no longer active)]

(In reply to comment #10)
> Is mconnor still the right reviewer here?

Yes, he's the only possible reviewer.

Comment 12

[Mike Connor [:mconnor]]

Comment on attachment 381301 [details] [diff] [review]
Patch + test


>+
>+    setTimeout(function () {
>+      if (DownloadMonitorPanel.inited())
>+        DownloadMonitorPanel.updateStatus();
>+    }, 0);
>   },

should we just make updateStatus check inited/call init() if something starts early?  Might be cleaner.  r=me either way.

Comment 13

[(no longer active)]

I made updateStatus bail out if inited returns false.  It can't call init itself because the download manager service is initialized in the delayedStartup function.

http://hg.mozilla.org/mozilla-central/rev/d0dadd3b71bb

Comment 14

[Aaron Train [:aaronmt]]

Verified FIXED on trunk

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090802 Minefield/3.6a1pre

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 381301 [details] [diff] [review]
Patch + test

Doesn't seem like the kind of fix we have to take on the stable branch. 1.9.1 approval denied.