Show more meaningful exception when keypress is targetted on a non-existent widget

VERIFIED FIXED

Status

Testing Graveyard
Mozmill
VERIFIED FIXED
9 years ago
a year ago

People

(Reporter: whimboo, Assigned: mikeal)

Tracking

Details

(Whiteboard: [verified-mozmill-1.2])

When we call keypress which uses the synthesizeKey function from the EventUtils.js module we get an exception if the target element is not visible. It's not really understandable what's going on. A more meaningful failure should be logged.

Currently we get:

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIDOMWindowUtils.sendKeyEvent]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
file:///Volumes/data/build/mozmill/trunk/mozmill/extension/resource/modules/EventUtils.js
:: synthesizeKey :: line 326"  data: no]
Source File:
file:///Volumes/data/build/mozmill/trunk/mozmill/extension/resource/modules/frame.js
Line: 411

Mikeal said on IRC that he wants to fix it right away.
(Assignee)

Comment 1

9 years ago
Fixed in r476.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Looks good. And I was wrong. The exception will be thrown for non-existent widgets and not for hidden ones. Sorry for my false interpretation.
Assignee: nobody → mrogers
Status: RESOLVED → VERIFIED
Summary: Show more meaningful exception when keypress is targetted on a hidden element → Show more meaningful exception when keypress is targetted on a non-existent widget
Whiteboard: [verified-mozmill-1.2]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.