496024 - Make use of iterators for dehydra's process callback

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[(dormant account)]

We've long had a top-secret process() callback(it never got documented) and convenience function called iter(). Unfortunately iter is written in a functional style and some have complained about it not using generators instead.

So I took this one step futher and made it so process() is passed a generator to variables in the current statement, this makes "grepping" a whole lot more convenient. Compare the example at http://www.kdedevelopers.org/node/3970
With:

function process(statement_items) {
  for each (var v in statement_items) {
    if (v.shortName == "strcpy")
      error("Evil")
  }
}

Would be nice if some JS expert confirmed that this is the right way(tm).

Comment 1

[(dormant account)]

Attachment: patch to dehydra.js

Comment 2

[Brendan Eich [:brendan]]

(In reply to comment #1)
> Created an attachment (id=381164) [details]
> patch to dehydra.js

Cc'ing better Pythonistas than a poser like me.

I like it -- "flat is better than nested" -- but that does not apply to the indentation :-P. Indent the inner for loops and their bodies appropriately.

Also, let goes with yield like a fish with a fighter-jet. Those vars are too old skool.

/be

Comment 3

[[e-mail]]

I'm guessing we can close this out now that we have iterate_vars()?