Closed
Bug 496056
Opened 15 years ago
Closed 15 years ago
RTL for notification boxes
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.6
People
(Reporter: jbalogh, Assigned: ehsan.akhgari)
References
Details
(Keywords: rtl)
Attachments
(2 files)
|
10.75 KB,
image/jpeg
|
Details | |
|
1.25 KB,
patch
|
wenzel
:
review+
|
Details | Diff | Splinter Review |
notification box in an rtl language
I'm guessing the icon should be on the other side.
|
||
Updated•15 years ago
|
Assignee: fwenzel → ehsan.akhgari
Severity: normal → minor
|
Assignee | |
Comment 1•15 years ago
|
||
(In reply to comment #0) > I'm guessing the icon should be on the other side. Yeah, but can you please let me know how to trigger this notification?
|
|
Assignee | |
Comment 2•15 years ago
|
||
This patch should take care of the RTL problems for all notification boxes
Attachment #381272 -
Flags: review?(clouserw)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 381272 [details] [diff] [review] Patch (v1) Of course, I fixed this before I saw that the assignee changed here ;) but this patch looks good. If you want, you can use "right" instead of "100%" but that's purely cosmetic.
Attachment #381272 -
Flags: review?(clouserw) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Committed in r26987 with s/100%/right/. Thanks for your review, Frédéric.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•15 years ago
|
||
Verified on https://preview.addons.mozilla.org/fa/firefox/addons/versions/1407.
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•