TM: "Assertion failure: original == thisv || original == OBJECT_TO_JSVAL(obj)" on eBay Motors

VERIFIED FIXED in mozilla1.9.1

Status

()

P1
critical
VERIFIED FIXED
10 years ago
7 years ago

People

(Reporter: jruderman, Assigned: gal)

Tracking

({assertion, verified1.9.1})

Trunk
mozilla1.9.1
x86
Mac OS X
assertion, verified1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey, URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
On mozilla-central, loading http://www.motors.ebay.com/ triggers:

Assertion failure: original == thisv || original == OBJECT_TO_JSVAL(obj), at /Users/jruderman/central/js/src/jstracer.cpp:6758
(Assignee)

Updated

10 years ago
Flags: blocking1.9.1?
Blocking per Andreas.
Flags: blocking1.9.1? → blocking1.9.1+
(Assignee)

Updated

10 years ago
Assignee: general → gal
Flags: blocking1.9.1+ → blocking1.9.1?
Priority: -- → P1
Target Milestone: --- → mozilla1.9.1
(Assignee)

Comment 2

10 years ago
Created attachment 381211 [details] [diff] [review]
patch

Updated

10 years ago
Flags: blocking1.9.1? → blocking1.9.1+
(Assignee)

Comment 3

10 years ago
Check whether a 'with' object is the original 'this' that was handed in, instead of checking after calling the 'this' hook. I really don't like wrappers and the 'this' hook and 'with', and here all are in one bug. Nice.
(Assignee)

Updated

10 years ago
Attachment #381211 - Flags: review?(mrbkap)
Comment on attachment 381211 [details] [diff] [review]
patch

No wrappers involved here, only with.
Attachment #381211 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 5

10 years ago
http://hg.mozilla.org/tracemonkey/rev/2e43c8da18a8
Whiteboard: fixed-in-tracemonkey
Yeah, go easy on wrappers :-P.

/be

Comment 7

10 years ago
http://hg.mozilla.org/mozilla-central/rev/2e43c8da18a8
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
How can that happen?
Flags: in-testsuite?
verified FIXED on debug builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090629 Shiretoko/3.5pre ID:20090629082025

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090629 Minefield/3.6a1pre ID:20090629082126
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.