Closed
Bug 496102
Opened 17 years ago
Closed 17 years ago
Remove nsNotifyPaintEvent
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file, 1 obsolete file)
|
14.19 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
MozAfterPaint is for DOM only, so it shouldn't need
nsXXXEvent. However, normal createEvent/initEvent is probably a bit too
slow for it, so the patch allows one to create an event fast using
NS_NewDOMNotifyPaintEvent.
Asking review after tryserver has run tests.
|
Assignee | |
Updated•17 years ago
|
Attachment #381277 -
Flags: superreview?(roc)
Attachment #381277 -
Flags: review?(roc)
|
|
Assignee | |
Updated•17 years ago
|
Attachment #381277 -
Flags: superreview?(roc)
Attachment #381277 -
Flags: review?(roc)
|
|
Assignee | |
Comment 1•17 years ago
|
||
Comment on attachment 381277 [details] [diff] [review]
patch
Um, there is something wrong. This didn't pass tryserver tests.
|
|
Assignee | |
Comment 2•17 years ago
|
||
Still waiting tryserver
Attachment #381277 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•17 years ago
|
Attachment #381311 -
Attachment is patch: true
Attachment #381311 -
Attachment mime type: application/octet-stream → text/plain
Attachment #381311 -
Flags: superreview?(roc)
Attachment #381311 -
Flags: review?(roc)
Attachment #381311 -
Flags: superreview?(roc)
Attachment #381311 -
Flags: superreview+
Attachment #381311 -
Flags: review?(roc)
Attachment #381311 -
Flags: review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 4•17 years ago
|
||
This seemed to have a caused an intermittent failure of /tests/layout/base/tests/test_bug450930.xhtml
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1245672642.1245674990.16560.gz
|
|
Assignee | |
Comment 5•17 years ago
|
||
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 6•17 years ago
|
||
It looks like the intermittent failure might have been happening before this landed. See bug 483218. Perhaps this was just unlikely. Certainly worth investigating though.
|
|
Assignee | |
Comment 7•17 years ago
|
||
The test does use timeouts in a way which may cause failures, I think.
|
|
Assignee | |
Comment 8•17 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•