496148 - Remove SAFESEH from Win build settings

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P4)

Description

[Rick Reitmaier]

This linker setting is probably no longer needed.

It was there for the BufferGuard work (i.e exception handlers) which have already been removed.

Comment 1

[Lars T Hansen]

Rick: In the shell project we add /SAFESEH:NO and it's used nowhere else.  Do you think we should remove that switch?

http://msdn.microsoft.com/en-us/library/9a89h429%28VS.80%29.aspx

Comment 2

[Rick Reitmaier]

Yes, we only had it there since we didn't register buffer guard as a exception handler to the OS.  

There is player code that does the registration properly and thus they're not using the switch.  If we need to , we can do the same, but I don't think bufferGuard is even in our code anymore , if it is we should stamp it out.

Comment 3

[Steven Johnson]

BufferGuard is loooong gone.

Comment 4

[Brent Baker]

Should this also be removed from the configure.py script?

http://hg.mozilla.org/tamarin-redux/annotate/tip/configure.py#l168
lhansen@1176 168        OS_LDFLAGS += "-SAFESEH:NO -MAP "

Comment 5

[Lars T Hansen]

Yes.  Thank you.

Comment 6

[Lars T Hansen]

Attachment: Patch

Comment 7

[Lars T Hansen]

tamarin-redux changeset:   4383:afe3bfb0f08f