If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Bookmarks toolbar icon/text backgrounds don't match

VERIFIED FIXED in Firefox 3.6a1

Status

()

Firefox
Theme
--
trivial
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: zpao, Assigned: dao)

Tracking

({polish, verified1.9.1})

Trunk
Firefox 3.6a1
x86
Mac OS X
polish, verified1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-easy][polish-visual][polish-p1])

Attachments

(3 attachments)

Created attachment 381341 [details]
Screenshot

There's a subtle difference in the greys between the text background & icon backgrounds in the bookmarks toolbar. It's visible in the attached screenshot & with the RSS icon for Latest Headlines as well.
Dolske pointed out this file in particular (which makes it painfully obvious): http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/toolbar/toolbarbutton-customhover-right.png
Whiteboard: [polish-easy]
(Assignee)

Comment 2

8 years ago
Created attachment 381410 [details]
fixed toolbarbutton-customhover-right.png
Assignee: nobody → dao
Attachment #381410 - Flags: approval1.9.1?
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/d42964db70c6
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Attachment #381410 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 381410 [details]
fixed toolbarbutton-customhover-right.png

a191=beltzner
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/309e0b284cab
Keywords: fixed1.9.1
I still see a problem, but now the opposite - the bg of the icon is darker than the bg of the text.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090611 Shiretoko/3.5pre ID:20090611030802 (Built from http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b3058f6658ec, so this patch is in there)
(Assignee)

Comment 7

8 years ago
I'm checking the changed icon and the related ones for color profiles or something like that ... in the meantime, could you please attach a screenshot?
Created attachment 382804 [details]
screenshot #2

screenshot demonstrating comment #6
(Assignee)

Comment 9

8 years ago
Alright, it's both a color profile and a gAMA chunk. Fixing...
(Assignee)

Comment 10

8 years ago
http://hg.mozilla.org/mozilla-central/rev/948e67818fe7
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9ab2eb19fb7b
verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090608 Shiretoko/3.5pre ID:20090608122057

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090608 Minefield/3.6a1pre ID:20090608122028
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.
Whiteboard: [polish-easy] → [polish-easy][polish-visual][polish-p1]
You need to log in before you can comment on or make changes to this bug.