496161 - Bookmarks toolbar icon/text backgrounds don't match

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Screenshot

There's a subtle difference in the greys between the text background & icon backgrounds in the bookmarks toolbar. It's visible in the attached screenshot & with the RSS icon for Latest Headlines as well.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Dolske pointed out this file in particular (which makes it painfully obvious): http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/toolbar/toolbarbutton-customhover-right.png

Comment 2

[Dão Gottwald [:dao]]

Attachment: fixed toolbarbutton-customhover-right.png

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d42964db70c6

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 381410 [details]
fixed toolbarbutton-customhover-right.png

a191=beltzner

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/309e0b284cab

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I still see a problem, but now the opposite - the bg of the icon is darker than the bg of the text.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090611 Shiretoko/3.5pre ID:20090611030802 (Built from http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b3058f6658ec, so this patch is in there)

Comment 7

[Dão Gottwald [:dao]]

I'm checking the changed icon and the related ones for color profiles or something like that ... in the meantime, could you please attach a screenshot?

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: screenshot #2

screenshot demonstrating comment #6

Comment 9

[Dão Gottwald [:dao]]

Alright, it's both a color profile and a gAMA chunk. Fixing...

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/948e67818fe7
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9ab2eb19fb7b

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090608 Shiretoko/3.5pre ID:20090608122057

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090608 Minefield/3.6a1pre ID:20090608122028

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.