496309 - focusElement and getBrowserFromContentWindow in utilityOverlay.js should be removed

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Neil Deakin]

After bug 178324, the focusElement function in utilityOverlay.js isn't useful. I left it for compatibility for now. There are only three callers, one which could just call gURLBar.focus() directly. The other two just need to focus a window which they could do with:

var browser = getBrowserFromContentWindow(content);
if (browser)
  browser.focus();

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Mike Connor [:mconnor]]

So... we're removing getBrowserFromContentWindow() which you cite in comment 0 as a way for consumers to not use focusElement()... can you explain why we're removing that method too?

Comment 3

[Dão Gottwald [:dao]]

getBrowserFromContentWindow(content) is gBrowser.selectedBrowser.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 393681 [details] [diff] [review]
patch

Yes, this is quite true, I didn't look into it at all.  Let's do this, though I would like to see if we can get a search on the AMO codebase DB to see if anyone's relying on either of these before we land it.

Comment 5

[Dão Gottwald [:dao]]

I'm actually pretty sure focusElement is used in the wild, as we used it in a few prominent places in browser.js and people tend to copy that. But in 3.6 it produces a warning suggesting what should be used instead, so I think removing it in 3.7 should be ok.

Comment 6

[Dão Gottwald [:dao]]

getBrowserFromContentWindow is used by Annoyance Remover, focusElement is used by Tab Mix Plus and RubNub for YubNub.

Comment 7

[Dão Gottwald [:dao]]

Once Annoyance Remover is updated to work with 3.5, it should use aBrowser instead of getBrowserFromContentWindow(aWebProgress.top).

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/38008241849d